Bug 663695

Summary:	Review Request: mingw32-sigar - MinGW Windows sigar library
Product:	[Fedora] Fedora	Reporter:	Andrew Beekhof <andrew>
Component:	Package Review	Assignee:	Jaroslav Reznik <jreznik>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, jreznik, notting
Target Milestone:	---	Flags:	jreznik: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-01-31 16:41:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Andrew Beekhof 2010-12-16 16:23:07 UTC

Description:

The Sigar API provides a portable interface for gathering system
information such as:
- System memory, swap, CPU, load average, uptime, logins
- Per-process memory, CPU, credential info, state, arguments,
  environment, open files
- File system detection and metrics
- Network interface detection, configuration info and metrics
- Network route and connection tables

This information is available in most operating systems, but each OS
has their own way(s) providing it. SIGAR provides developers with one
API to access this information regardless of the underlying platform.


The mingw version will be used for the windows version matahari.


SPEC: http://www.clusterlabs.org/~beekhof/mingw32-sigar.spec
SRPM:
http://www.clusterlabs.org/~beekhof/matahari/fedora-14/SRPMS/mingw32-sigar-1.6.5-0.1.git833ca18.fc14.src.rpm

Comment 1 Jaroslav Reznik 2010-12-21 11:37:10 UTC

Sigar review: https://bugzilla.redhat.com/show_bug.cgi?id=659679

Mingw32 specific review:
Stripping: ok
Name: ok (mingw32- prefix)
BuildRequires: ok, mingw32-filesystem >= minimum-version found
BuildArch: noarch, ok
Libraries: ok
DLL listed explicitly: ok

Builds: scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2680781 ok

Missing dependencies generator code (http://fedoraproject.org/wiki/Packaging/MinGW#Dependencies)

%global _use_internal_dependency_generator 0
%global __find_requires %{_mingw32_findrequires}
%global __find_provides %{_mingw32_findprovides}

Comment 2 Andrew Beekhof 2010-12-21 12:25:51 UTC

SPEC and SRPM updated:

SPEC: http://www.clusterlabs.org/~beekhof/mingw32-sigar.spec
SRPM:
http://www.clusterlabs.org/~beekhof/matahari/fedora-14/SRPMS/mingw32-sigar-1.6.5-0.2.git833ca18.fc14.src.rpm

Comment 3 Jaroslav Reznik 2010-12-21 12:33:50 UTC

Thanks Andrew!

APPROVED

PS: just a minor, review non-blocking rpmlint issue: mingw32-sigar.src:36: W: mixed-use-of-spaces-and-tabs (spaces: line 36, tab: line 9), please, fix later in commit

Comment 4 Andrew Beekhof 2010-12-21 12:39:27 UTC

New Package SCM Request
=======================
Package Name: mingw32-sigar
Short Description: MinGW Windows sigar library
Owners: beekhof
Branches: f14 devel
InitialCC:

Comment 5 Jason Tibbitts 2010-12-21 16:03:12 UTC

Git done (by process-git-requests).