Fedora Account System
Red Hat Associate
Red Hat Customer
Description: The Sigar API provides a portable interface for gathering system information such as: - System memory, swap, CPU, load average, uptime, logins - Per-process memory, CPU, credential info, state, arguments, environment, open files - File system detection and metrics - Network interface detection, configuration info and metrics - Network route and connection tables This information is available in most operating systems, but each OS has their own way(s) providing it. SIGAR provides developers with one API to access this information regardless of the underlying platform. SPEC: http://www.clusterlabs.org/~beekhof/sigar.spec SRPM: http://repos.fedorapeople.org/repos/beekhof/matahari/fedora-13/SRPMS/sigar-1.6.4-1.fc13.src.rpm
rpmlint output: rpmlint sigar.spec sigar.spec:6: W: non-standard-group Libraries > not ok sigar.spec:10: W: macro-in-comment %{name} sigar.spec:10: W: macro-in-comment %{name} sigar.spec:10: W: macro-in-comment %{version} sigar.spec:44: W: macro-in-comment %{name} sigar.spec:44: W: macro-in-comment %{version} > ok sigar.spec: W: invalid-url Source0: sigar-1.6.4.tbz2 > not ok 0 packages and 1 specfiles checked; 0 errors, 7 warnings. rpmlint ../RPMS/x86_64/sigar-1.6.4-1.fc14.x86_64.rpm sigar.x86_64: W: name-repeated-in-summary C SIGAR > ok sigar.x86_64: W: spelling-error %description -l en_US uptime -> optime, up time, up-time sigar.x86_64: W: spelling-error %description -l en_US logins -> losing, login, loins > ok sigar.x86_64: W: non-standard-group Libraries sigar.x86_64: W: incoherent-version-in-changelog 1.6.0-1 ['1.6.4-1.fc14', '1.6.4-1'] > please fix sigar.x86_64: E: invalid-soname /usr/lib64/libsigar.so libsigar.so > unversioned library sigar.x86_64: W: shared-lib-calls-exit /usr/lib64/libsigar.so exit.5 > should be fixed 1 packages and 0 specfiles checked; 1 errors, 6 warnings. Name: ok Version & release: ok Summary: ok Group: not ok - should be "System Environment/Libraries" License: ok, ASL 2.0 URL: ok (redirects to http://support.hyperic.com/display/SIGAR/Home) Source: not ok Source MD5: can't check - no 1.6.4 binaries at provided URL Consistent usage of macros: ok Buildroot: ok (not required anymore but Sigar should go to older releases too) Devel subpackage: ok Non-devel subpackage contains .so: yes, shared lib should be properly versioned, .so symlink should go to -devel subpackage!!! ldconfig snippet: not ok, missing http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Shared_libraries Documentation: missing LICENSE NOTICE AUTHORS from upstreams tarball - please fix at least LICENSE - the must item
That was lazy of me, I should have run rpmlint myself. New links: http://www.clusterlabs.org/~beekhof/sigar.spec http://www.clusterlabs.org/~beekhof/matahari/fedora-14/SRPMS/sigar-1.6.5-0.1.git833ca18.fc14.src.rpm New rpmlint output: [04:54 PM] beekhof@f13 ~/rpmbuild/SOURCES # rpmlint fedora-14/x86_64/sigar-*.5* ../SPECS/sigar.spec sigar.x86_64: W: spelling-error %description -l en_US uptime -> optime, up time, up-time sigar.x86_64: W: spelling-error %description -l en_US logins -> losing, login, loins These first two warnings are bogus spelling "errors". sigar.x86_64: E: invalid-soname /usr/lib64/libsigar.so libsigar.so Upstream has no concept of SO versioning and I am loathed to invent one. I'm prepared to work with upstream to get this added, however until that time I would prefer to leave it unversioned. sigar.x86_64: W: shared-lib-calls-exit /usr/lib64/libsigar.so exit.5 The use of exit() appears to be intentional and appropriate. ../SPECS/sigar.spec: W: invalid-url Source0: sigar-1.6.5-833ca18.tbz2 The last refers to the tarball. Unfortunately we need to use git archives as the published tarballs do not support cmake and the diff to the last release is massive. This and the steps for regenerating the tarball have been included in the spec file. 3 packages and 1 specfiles checked; 1 errors, 4 warnings.
Thanks Andrew! Package builds locally and Koji build works too http://koji.fedoraproject.org/koji/taskinfo?taskID=2669946, all issues fixed. APPROVED
New Package SCM Request ======================= Package Name: sigar Short Description: System Information Gatherer And Reporter Owners: beekhof Branches: f14 devel InitialCC:
The ticket summary says "Sigar" but the requested package name is "sigar". Which is actually desired? Please either correct the summary or the SCM request and re-raise the fedora-cvs flag.
Sorry about that. The SCM request (lowercase) was correct. Updated the summary accordingly and re-raising cvs flag.
Git done (by process-git-requests).