Bug 663914
| Summary: | Review Request: rubygem-fssm - File system state monitor | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
| Component: | Package Review | Assignee: | Michal Fojtik <mfojtik> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mfojtik, notting, pahan |
| Target Milestone: | --- | Flags: | mfojtik:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-fssm-0.2.2-3.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-01-18 21:34:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Vít Ondruch
2010-12-17 10:31:56 UTC
Taking this one for a review. Spec URL: http://people.redhat.com/vondruch/rubygem-fssm.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-fssm-0.2.2-2.fc14.src.rpm Documentation moved into sub-package. ==== Package approved by mfojtik =====
Some notes, please fix that before you import this package to Fedora packages:
* Requires: rubygem(rspec) >= 0
I'm not sure, if >=0 is required here. You can use just rubygem(rspec)
* %{geminstdir}/fssm.gemspec
Please replace 'fssm' with macro you defined at the top %gemname
Format review:
[OK] Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification.
[OK] The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version
[OK] The package must have a Requires and a BuildRequires on rubygems
[OK] The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification.
[OK] For every dependency on a Gem named gemdep, the package must contain a Requires on rubygem(%{gemdep}) with the same version constraints as the Gem
[OK] The %prep and %build sections of the specfile should be empty.
[OK] The Gem must be installed into %{gemdir} defined as
%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)
[OK] The package must own the following files and directories:
%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec
[OK] If the Gem only contains pure Ruby code, it must be marked as BuildArch: noarch.
New Package SCM Request ======================= Package Name: rubygem-fssm Short Description: File system state monitor Owners: vondruch Branches: f14 Git done (by process-git-requests). rubygem-fssm-0.2.2-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-fssm-0.2.2-3.fc14 rubygem-fssm-0.2.2-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-fssm'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-fssm-0.2.2-3.fc14 rubygem-fssm-0.2.2-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |