Bug 663914 - Review Request: rubygem-fssm - File system state monitor
Summary: Review Request: rubygem-fssm - File system state monitor
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michal Fojtik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-12-17 10:31 UTC by Vít Ondruch
Modified: 2011-01-18 21:34 UTC (History)
4 users (show)

Fixed In Version: rubygem-fssm-0.2.2-3.fc14
Clone Of:
Environment:
Last Closed: 2011-01-18 21:34:05 UTC
Type: ---
Embargoed:
mfojtik: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Vít Ondruch 2010-12-17 10:31:56 UTC
Spec URL: http://people.redhat.com/vondruch/rubygem-fssm.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-fssm-0.2.2-1.fc14.src.rpm

Description: The File System State Monitor keeps track of the state of any number of paths and will fire events when said state changes (create/update/delete). FSSM supports using FSEvents on MacOS (with ruby 1.8), Inotify on GNU/Linux, and polling anywhere else.

Comment 1 Michal Fojtik 2010-12-17 11:48:38 UTC
Taking this one for a review.

Comment 2 Vít Ondruch 2010-12-17 13:34:53 UTC
Spec URL: http://people.redhat.com/vondruch/rubygem-fssm.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-fssm-0.2.2-2.fc14.src.rpm

Documentation moved into sub-package.

Comment 3 Michal Fojtik 2011-01-07 09:34:45 UTC
==== Package approved by mfojtik =====

Some notes, please fix that before you import this package to Fedora packages:

* Requires: rubygem(rspec) >= 0
  I'm not sure, if >=0 is required here. You can use just rubygem(rspec)

* %{geminstdir}/fssm.gemspec
  Please replace 'fssm' with macro you defined at the top %gemname

Format review:


[OK] Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification.

[OK] The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version

[OK] The package must have a Requires and a BuildRequires on rubygems
    
[OK] The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification. 

[OK] For every dependency on a Gem named gemdep, the package must contain a Requires on rubygem(%{gemdep}) with the same version constraints as the Gem

[OK] The %prep and %build sections of the specfile should be empty.
[OK] The Gem must be installed into %{gemdir} defined as 
     %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)

[OK] The package must own the following files and directories: 

%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec

[OK] If the Gem only contains pure Ruby code, it must be marked as BuildArch: noarch.

Comment 4 Vít Ondruch 2011-01-07 13:01:49 UTC
New Package SCM Request
=======================
Package Name: rubygem-fssm
Short Description: File system state monitor
Owners: vondruch
Branches: f14

Comment 5 Jason Tibbitts 2011-01-07 17:27:01 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2011-01-10 16:18:14 UTC
rubygem-fssm-0.2.2-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-fssm-0.2.2-3.fc14

Comment 7 Fedora Update System 2011-01-10 21:29:07 UTC
rubygem-fssm-0.2.2-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rubygem-fssm'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-fssm-0.2.2-3.fc14

Comment 8 Fedora Update System 2011-01-18 21:34:00 UTC
rubygem-fssm-0.2.2-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.