Bug 664474

Summary:	calls to i2d_X509 when certificate_blob_size is unsigned
Product:	[Fedora] Fedora	Reporter:	Sami Farin <hvtaifwkbgefbaei>
Component:	ecryptfs-utils	Assignee:	Michal Hlavinka <mhlavink>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	esandeen, karsten, kevin, mhlavink
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ecryptfs-utils-84-2.fc13	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-01-04 13:42:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sami Farin 2010-12-20 14:48:24 UTC

Description of problem:
in src/key_mod/ecryptfs_key_mod_pkcs11_helper.c, expression
  if ((subgraph_key_ctx->pkcs11h_data.certificate_blob_size = i2d_X509 (x509, NULL)) < 0  )
is never true because certificate_blob_size is unsigned.

Version-Release number of selected component (if applicable):
84

How reproducible:
always

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Michal Hlavinka 2011-01-04 13:25:21 UTC

thanks, fixed in ecryptfs-utils-84-2.fc* with -Wtype-limits added to build options which should (together with -Werror) prevent this in future

Comment 2 Fedora Update System 2011-01-04 14:50:53 UTC

ecryptfs-utils-84-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/ecryptfs-utils-84-2.fc13

Comment 3 Fedora Update System 2011-01-04 14:51:00 UTC

ecryptfs-utils-84-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/ecryptfs-utils-84-2.fc14

Comment 4 Fedora Update System 2011-01-17 20:53:09 UTC

ecryptfs-utils-84-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 5 Fedora Update System 2011-01-17 20:56:34 UTC

ecryptfs-utils-84-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.