Bug 666887

Summary:	darktable ftbfs against eviv2-0.21
Product:	[Fedora] Fedora	Reporter:	Rex Dieter <rdieter>
Component:	darktable	Assignee:	Edouard Bourguignon <madko>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	madko
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-01-04 11:59:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	666857

Description Rex Dieter 2011-01-03 16:27:52 UTC

darktable failed rebuilding against exiv2-0.21

common/exif.cc:36:29: fatal error: exiv2/canonmn.hpp: No such file or directory
compilation terminated.

Indeed, exiv2 no longer provides that interface header.

Comment 1 Rex Dieter 2011-01-03 16:28:26 UTC

fyi,
http://koji.fedoraproject.org/koji/buildinfo?buildID=212191

any assistance to resolve this would be appreciated.

Comment 2 Edouard Bourguignon 2011-01-03 17:01:18 UTC

seems the file canonmn.hpp has been renamed to canonmn_int.hpp

Comment 3 Edouard Bourguignon 2011-01-03 17:34:43 UTC

not only the canon header is missing, pentax sony etc are missing too

Comment 4 Rex Dieter 2011-01-03 17:48:57 UTC

Per,
http://www.exiv2.org/whatsnew.html#item1

The new exiv2.hpp umbrella header file further shields applications from library changes.

maybe could try using that instead?  (provided darktable doesn't use any deprecated apis)

Comment 5 Edouard Bourguignon 2011-01-03 18:08:09 UTC

Good catch, it's building with this patch

diff -Naur darktable-0.7.orig/src/common/exif.cc darktable-0.7/src/common/exif.cc
--- darktable-0.7.orig/src/common/exif.cc	2010-11-20 12:35:27.000000000 +0100
+++ darktable-0.7/src/common/exif.cc	2011-01-03 19:05:34.242131001 +0100
@@ -29,11 +29,7 @@
 #include "common/imageio.h"
 }
 // #include <libexif/exif-data.h>
-#include <exiv2/xmp.hpp>
-#include <exiv2/error.hpp>
-#include <exiv2/image.hpp>
-#include <exiv2/exif.hpp>
-#include <exiv2/canonmn.hpp>
+#include <exiv2/exiv2.hpp>
 #include <sqlite3.h>
 #include <iostream>
 #include <fstream>

Comment 6 Edouard Bourguignon 2011-01-04 10:22:49 UTC

http://koji.fedoraproject.org/koji/buildinfo?buildID=212493 I think we can close the bug?

Comment 7 Rex Dieter 2011-01-04 11:59:56 UTC

indeed, thanks!

(and send your patch to darktable upstream)

Comment 8 Edouard Bourguignon 2011-01-07 13:24:13 UTC

I send the patch to upstream but they told be that was already fixed in their git version. Maybe we could use a git version of darktable for rawhide? At least they confirmed the patch is ok.