darktable failed rebuilding against exiv2-0.21 common/exif.cc:36:29: fatal error: exiv2/canonmn.hpp: No such file or directory compilation terminated. Indeed, exiv2 no longer provides that interface header.
fyi, http://koji.fedoraproject.org/koji/buildinfo?buildID=212191 any assistance to resolve this would be appreciated.
seems the file canonmn.hpp has been renamed to canonmn_int.hpp
not only the canon header is missing, pentax sony etc are missing too
Per, http://www.exiv2.org/whatsnew.html#item1 The new exiv2.hpp umbrella header file further shields applications from library changes. maybe could try using that instead? (provided darktable doesn't use any deprecated apis)
Good catch, it's building with this patch diff -Naur darktable-0.7.orig/src/common/exif.cc darktable-0.7/src/common/exif.cc --- darktable-0.7.orig/src/common/exif.cc 2010-11-20 12:35:27.000000000 +0100 +++ darktable-0.7/src/common/exif.cc 2011-01-03 19:05:34.242131001 +0100 @@ -29,11 +29,7 @@ #include "common/imageio.h" } // #include <libexif/exif-data.h> -#include <exiv2/xmp.hpp> -#include <exiv2/error.hpp> -#include <exiv2/image.hpp> -#include <exiv2/exif.hpp> -#include <exiv2/canonmn.hpp> +#include <exiv2/exiv2.hpp> #include <sqlite3.h> #include <iostream> #include <fstream>
http://koji.fedoraproject.org/koji/buildinfo?buildID=212493 I think we can close the bug?
indeed, thanks! (and send your patch to darktable upstream)
I send the patch to upstream but they told be that was already fixed in their git version. Maybe we could use a git version of darktable for rawhide? At least they confirmed the patch is ok.