Bug 670088

Spec URL: http://ricky.fedorapeople.org/pkgs/smlnj/smlnj.spec
SRPM URL: http://ricky.fedorapeople.org/pkgs/smlnj/smlnj-110.73-1.fc15.src.rpm

Updated to latest upstream version (110.73).

(In reply to comment #1)
> Spec URL: http://ricky.fedorapeople.org/pkgs/smlnj/smlnj.spec
> SRPM URL: http://ricky.fedorapeople.org/pkgs/smlnj/smlnj-110.73-1.fc15.src.rpm
> 
> Updated to latest upstream version (110.73).

I'm not able to build with this spec file using F14:

$ rpmbuild -ba smlnj.spec 
error: Architecture is not included: x86_64
$ 

Here are the steps to reproduce:

wget http://ricky.fedorapeople.org/pkgs/smlnj/smlnj-110.73-1.fc15.src.rpm
rpm -Uvh smlnj-110.73-1.fc15.src.rpm
cd rpmbuild/SPECS/
rpmbuild -ba smlnj.spec

Regards,

Brock

(In reply to comment #2)
> I'm not able to build with this spec file using F14:
> 
> $ rpmbuild -ba smlnj.spec 
> error: Architecture is not included: x86_64
> $ 

I get the same error with F15 on x86_64 ...

Hey, glad to have some eyes on this package :-)

It doesn't build on x86_64 because smlnj does not support x86_64 (see the last FAQ entry at http://www.smlnj.org/dist/working/110.73/NOTES/INSTALL).  Luckily,  the 32-bit version builds and runs fine on an x86_64 machine.  Just install glibc-devel.i686 and libgcc.i686, and you should be able to build it with rpmbuild --target i686 -ba smlnj.spec (I usually find it more convenient to just do a koji scratch build though).

(In reply to comment #4)
> Hey, glad to have some eyes on this package :-)

Hi Ricky,

Glad to help, thank you for your packages! :D

> 
> It doesn't build on x86_64 because smlnj does not support x86_64 (see the last
> FAQ entry at http://www.smlnj.org/dist/working/110.73/NOTES/INSTALL).  Luckily,
>  the 32-bit version builds and runs fine on an x86_64 machine.  Just install
> glibc-devel.i686 and libgcc.i686, and you should be able to build it with
> rpmbuild --target i686 -ba smlnj.spec (I usually find it more convenient to
> just do a koji scratch build though).

From a fresh F15 install (needed because the glibc-devel.i686 and libcc.i686 packages need to match n-v-r with the already installed ones, and an older F15 install might not match) I was able to download, compile from source, and install the smlnj packages from your url:

yum -y install glibc-devel.i686 libgcc.i686
wget http://ricky.fedorapeople.org/pkgs/smlnj/smlnj-110.73-1.fc15.src.rpm
rpm -Uvh smlnj-110.73-1.fc15.src.rpm
cd rpmbuild/SPECS/
rpmbuild --target i686 -ba smlnj.spec
rpm -Uvh /root/rpmbuild/RPMS/i686/smlnj-110.73-1.fc15.i686.rpm
/usr/bin/sml

Thanks for your help, Ricky! :D

Regards,

Brock

(In reply to comment #5)
> From a fresh F15 install 

For others trying to reproduce this behavior, let me be clear:

My fresh F15 install was a default "Software Development" install on x86_64 ...


> yum -y install glibc-devel.i686 libgcc.i686
> wget http://ricky.fedorapeople.org/pkgs/smlnj/smlnj-110.73-1.fc15.src.rpm
> rpm -Uvh smlnj-110.73-1.fc15.src.rpm
> cd rpmbuild/SPECS/
> rpmbuild --target i686 -ba smlnj.spec
> rpm -Uvh /root/rpmbuild/RPMS/i686/smlnj-110.73-1.fc15.i686.rpm
> /usr/bin/sml
> 

Regards,

Brock

Hi Ricky,

What is the next part of the review request?

Regards,

Brock

Ricky,

it fails to build in rawhide and f16:

./config/install.sh: Using shell /bin/sh.
./config/install.sh: SML root is /builddir/build/BUILD/smlnj-110.73.
./config/install.sh: Installation directory is /builddir/build/BUILD/smlnj-110.73.
./config/install.sh: Installing version 110.73.
./config/install.sh: URL of source archive is http://smlnj.cs.uchicago.edu/dist/working/110.73/.
./config/install.sh: !!! Script /builddir/build/BUILD/smlnj-110.73/bin/.arch-n-opsys fails on this machine.
./config/install.sh: !!! You must patch this by hand and repeat the installation.
error: Bad exit status from /var/tmp/rpm-tmp.Bv0cKg (%build)


Checking bin/.arch-n-opsys, I see that it's explicitly checking `uname -r` against 2.[2-6].* and failing because the kernel's been bumped to 3.x now.

This will let it build on later kernels

diff -uNr config/_arch-n-opsys config-new/_arch-n-opsys
--- config/_arch-n-opsys	2011-03-22 09:30:14.000000000 -0400
+++ config-new/_arch-n-opsys	2012-03-28 08:57:09.729873343 -0400
@@ -94,6 +94,7 @@
 	  2.4.*) ;;
 	  2.5.*) ;;
 	  2.6.*) ;;
+	  3.*) ;;
 	  *) exit 1 ;;
 	esac
 	;;

Latest upstream version, 110.74 should also build on 3.x kernels.

This works without modification (except removing ExclusiveArch  + version number changes) with current 110.75.

It would be nice to see this in Fedora, but I don't know enough about it to maintain it, or really even move this review along, but just wanted to mention that it works with the latest version, for anyone who needs it.

There has not been any comment in a long time.

Are you intending to progress this?

If there is no response within a week this bug will be closed as per policy.

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

(In reply to James Hogarth from comment #13)
> There has not been any comment in a long time.
> 
> Are you intending to progress this?
> 
> If there is no response within a week this bug will be closed as per policy.
> 
> https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

Ricky no longer works at Red Hat (since Jan 2012).

(In reply to Tom "spot" Callaway from comment #14)
> (In reply to James Hogarth from comment #13)
> > There has not been any comment in a long time.
> > 
> > Are you intending to progress this?
> > 
> > If there is no response within a week this bug will be closed as per policy.
> > 
> > https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
> 
> Ricky no longer works at Red Hat (since Jan 2012).

Thanks Tom

I'll close this then so that it's not in the queue and if anyone else has interest they can open a fresh review request.

*** This bug has been marked as a duplicate of bug 1421506 ***