Bug 671003
| Summary: | /etc/profile.d/cvs.csh uses non-tcsh syntax | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Corinna Vinschen <vinschen> | |
| Component: | cvs | Assignee: | Petr Pisar <ppisar> | |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | high | Docs Contact: | ||
| Priority: | low | |||
| Version: | 14 | CC: | ppisar | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | cvs-1.11.23-11.fc13 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 671145 684785 (view as bug list) | Environment: | ||
| Last Closed: | 2011-01-28 19:17:47 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
Oops, I missed to set CVS_RSH to ssh. So, here the *corrected*
correct syntax for csh and tcsh:
if ( "$?CVS_RSH" == 0 ) setenv CVS_RSH ssh
Sorry about that,
Corinna
Thank you for the report. Nobody uses csh probably. F15--13 affected. cvs-1.11.23-12.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/cvs-1.11.23-12.fc14 cvs-1.11.23-11.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/cvs-1.11.23-11.fc13 cvs-1.11.23-12.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cvs'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/cvs-1.11.23-12.fc14 cvs-1.11.23-12.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. cvs-1.11.23-11.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: Here's the content of the csh profile /etc/profile.d/cvs.csh: # change default from rsh to ssh for cvs command setenv CVS_RSH "${CVS_RSH-ssh}" This is not valid tcsh syntax. This kind of variable substitution is only valid in POSIX shells. Right now, this bug does not result in an error when starting tcsh, but only because current tcsh versions ignore that line for the simple reason that it's missing a newline. However, the upcoming tcsh 6.18.00 will NOT ignore that last line anymore and a syntax error will occur. The correct syntax for csh and tcsh is if ( "$?CVS_RSH" == 0 ) setenv CVS_RSH I hope this can be fixed soon. And, please add a newline since otherwise the line will never be executed with the current tcsh 6.17.00. Thanks, Corinna