Bug 671187

Summary: .git in sources tarball
Product: Red Hat Enterprise Linux 6 Reporter: Jay Greguske <jgreguske>
Component: virtio-winAssignee: Jay Greguske <jgreguske>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 6.0CC: cpelland, mjenner, qzhang, tburke, vrozenfe, ykaul
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-04-25 17:26:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jay Greguske 2011-01-20 17:38:17 UTC 
Description of problem:

The sources tarball includes the .git directory from a checkout. This is harmless, but it should not be included.

Version-Release number of selected component (if applicable): 1.1.16-0
Comment 2 Dor Laor 2011-02-01 10:28:13 UTC 
Can you close the bug now?
Comment 3 Jay Greguske 2011-02-10 19:46:47 UTC 
Not yet. When a 6.1 advisory is filed I'll add this bug to it. (or Vadim can)
Comment 5 Qunfang Zhang 2011-02-18 06:58:03 UTC 
Hi, Jay
This bug is fixed in 1.1.16-1 right?
I can reproduce in 1.1.16-0, but verified in the following build:
https://brewweb.devel.redhat.com/buildinfo?buildID=156648

Seems the .git directory still exists.

Steps:
1. download virtio-win-1.1.16-1.el6.src.rpm from the above link.
2.#rpm -ivh virtio-win-1.1.16-1.el6.src.rpm
3.#cd rpmbuild/
  #cd SOURCES/
  #tar -xvf virtio-win-1.1.16.tar.bz2
  #ls
   virtio-win-1.1.16                     virtio-win-1.1.16.1-drivers.zip
   virtio-win-1.1.16.1-bin-whql.tar.bz2  virtio-win-1.1.16.tar.bz2
  #cd virtio-win-1.1.16
  #ls -a
   .   Balloon  .git        LICENSE  rmwhite.rb  vioserial  VirtIO
   ..  COPYING  .gitignore  NetKVM   status.txt  viostor

  #cd .git
   config       HEAD   index  logs     ORIG_HEAD    refs
   description  hooks  info   objects  packed-refs
Comment 8 Jay Greguske 2011-03-18 17:53:16 UTC 
Ugh, I completely forgot about this bug. I'm not sure a Low/Low bug should be an exception, but I'll double check and build again Monday.

Dor when should I expect new drivers to submit to Winqual for 6.1?
Comment 12 Jay Greguske 2011-03-24 12:13:40 UTC 
There you go
Comment 14 Jay Greguske 2011-04-25 17:26:26 UTC 
Cleaning out old bugs. Feel free to reopen if you feel this one was closed in error.