Bug 672136
| Summary: | Review Request: rubygem-multimap - Ruby multimap implementation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mo Morsi <mmorsi> |
| Component: | Package Review | Assignee: | Vít Ondruch <vondruch> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, notting, vondruch |
| Target Milestone: | --- | Flags: | vondruch:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-01-26 18:03:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 667997 | ||
|
Description
Mo Morsi
2011-01-24 05:00:06 UTC
I am taking this review. * Package looks good, rpmlint looks good, passes the review guidelines.
* Cleaning
- "rm -rf %{buildroot}" at the top of %install, %clean section
are no longer needed:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
* Splitting out document files
- Please consider to create -doc subpackage and move the following
files / directories into -doc
----------------------------------------------------
%doc %{gemdir}/doc/%{gemname}-%{version}
%doc %{geminstdir}/Rakefile
%doc %{geminstdir}/spec
%doc %{geminstdir}/%{gemname}.gemspec
----------------------------------------------------
* Test execution
- Please consider test execution just using "spec spec/" instead of "rake spec".
This would allow to omit the Rakefile and .gemspec as well as build
dependency on Rake.
However, neither of this is blocker:
APPROVED
Hey thanks for the review / approval. Incorporated your feedback into an updated version SPEC: http://mo.morsi.org/files/rpms/rubygem-multimap.spec SRPM: http://mo.morsi.org/files/rpms/rubygem-multimap-1.1.2-2.fc14.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2740138 (In reply to comment #2) > * Package looks good, rpmlint looks good, passes the review guidelines. > > * Cleaning > - "rm -rf %{buildroot}" at the top of %install, %clean section > are no longer needed: > https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean > Done. > * Splitting out document files > - Please consider to create -doc subpackage and move the following > files / directories into -doc > ---------------------------------------------------- > %doc %{gemdir}/doc/%{gemname}-%{version} > %doc %{geminstdir}/Rakefile > %doc %{geminstdir}/spec > %doc %{geminstdir}/%{gemname}.gemspec > ---------------------------------------------------- > Done. > * Test execution > - Please consider test execution just using "spec spec/" instead of "rake > spec". > This would allow to omit the Rakefile and .gemspec as well as build > dependency on Rake. > Done. > > However, neither of this is blocker: > > APPROVED New Package SCM Request ======================= Package Name: rubygem-multimap Short Description: Ruby multimap implementation Owners: mmorsi Branches: This ticket is not assigned to anyone. Please fix a nd re-raise the fedora-cvs flag. Git done (by process-git-requests). Pushed to rawhide. |