Hide Forgot
SPEC: http://mo.morsi.org/files/rpms/rubygem-multimap.spec SRPM: http://mo.morsi.org/files/rpms/rubygem-multimap-1.1.2-1.fc14.src.rpm Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2738866 Description: Multimap includes a Ruby multimap implementation
I am taking this review.
* Package looks good, rpmlint looks good, passes the review guidelines. * Cleaning - "rm -rf %{buildroot}" at the top of %install, %clean section are no longer needed: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean * Splitting out document files - Please consider to create -doc subpackage and move the following files / directories into -doc ---------------------------------------------------- %doc %{gemdir}/doc/%{gemname}-%{version} %doc %{geminstdir}/Rakefile %doc %{geminstdir}/spec %doc %{geminstdir}/%{gemname}.gemspec ---------------------------------------------------- * Test execution - Please consider test execution just using "spec spec/" instead of "rake spec". This would allow to omit the Rakefile and .gemspec as well as build dependency on Rake. However, neither of this is blocker: APPROVED
Hey thanks for the review / approval. Incorporated your feedback into an updated version SPEC: http://mo.morsi.org/files/rpms/rubygem-multimap.spec SRPM: http://mo.morsi.org/files/rpms/rubygem-multimap-1.1.2-2.fc14.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2740138 (In reply to comment #2) > * Package looks good, rpmlint looks good, passes the review guidelines. > > * Cleaning > - "rm -rf %{buildroot}" at the top of %install, %clean section > are no longer needed: > https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean > Done. > * Splitting out document files > - Please consider to create -doc subpackage and move the following > files / directories into -doc > ---------------------------------------------------- > %doc %{gemdir}/doc/%{gemname}-%{version} > %doc %{geminstdir}/Rakefile > %doc %{geminstdir}/spec > %doc %{geminstdir}/%{gemname}.gemspec > ---------------------------------------------------- > Done. > * Test execution > - Please consider test execution just using "spec spec/" instead of "rake > spec". > This would allow to omit the Rakefile and .gemspec as well as build > dependency on Rake. > Done. > > However, neither of this is blocker: > > APPROVED New Package SCM Request ======================= Package Name: rubygem-multimap Short Description: Ruby multimap implementation Owners: mmorsi Branches:
This ticket is not assigned to anyone. Please fix a nd re-raise the fedora-cvs flag.
Git done (by process-git-requests).
Pushed to rawhide.