Bug 672827

Summary: virt-v2v should use core libguestfs inspection
Product: [Community] Virtualization Tools Reporter: Richard W.M. Jones <rjones>
Component: virt-v2vAssignee: Matthew Booth <mbooth>
Status: CLOSED UPSTREAM QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecified   
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 672824
: 672831 (view as bug list) Environment:
Last Closed: 2011-04-13 20:34:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 672824, 672831, 673066, 674130, 679354, 732637    

Description Richard W.M. Jones 2011-01-26 14:47:12 UTC
The Perl inspection code in libguestfs (ie. Sys::Guestfs::Lib)
is obsolete and deprecated upstream.

Either: virt-v2v should move all this code into its own codebase
and maintain it there.

Or: [better] virt-v2v should be changed to use the core inspection
API.  See:
http://libguestfs.org/guestfs.3.html#inspection

+++ This bug was initially created as a clone of Bug #672824 +++

Description of problem:

https://www.redhat.com/archives/virt-tools-list/2011-January/thread.html#00058

If a Windows <= 2003 guest has the Windows Recovery Console
installed, then the perl inspection code detects this as an
extra instance of Windows.  Since virt-v2v does not work with
multiboot operating systems, the conversion fails with the
error:

 virt-v2v: multiboot operating systems are not supported by virt-v2v

Version-Release number of selected component (if applicable):

0.7.1(?)

How reproducible:

Always.

Steps to Reproduce:
1. Install Windows Recovery Console to the guest hard disk.
2. Try virt-v2v conversion.
3.
  
Actual results:

virt-v2v/libguestfs thinks the guest is multiboot and fails.

Expected results:

virt-v2v should ignore the Recovery Console partition and
convert only the main partition.  It should probably warn that
the Recovery Console has not been converted and must be
reinstalled.

Additional info:

Comment 1 Richard W.M. Jones 2011-03-24 11:48:33 UTC
Patch posted:

https://www.redhat.com/archives/libguestfs/2011-March/msg00122.html