Bug 674130 - Inspection code fails for Windows guest with two disks
Summary: Inspection code fails for Windows guest with two disks
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
Depends On: 672827
Blocks: 679354
TreeView+ depends on / blocked
 
Reported: 2011-01-31 18:08 UTC by Richard W.M. Jones
Modified: 2018-11-14 14:57 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-28 09:40:51 UTC


Attachments (Terms of Use)

Description Richard W.M. Jones 2011-01-31 18:08:04 UTC
Description of problem:

See:
https://www.redhat.com/archives/virt-tools-list/2011-January/msg00118.html

The inspection code gets confused if two partitions
contains what it thinks are Windows root filesystems.
Essentially the Windows root detection test is wrong:

http://git.annexia.org/?p=libguestfs.git;a=blob;f=src/inspect.c;h=ac2050c69491aee8dad3642c6a973275495ad823;hb=HEAD#l368
http://git.annexia.org/?p=libguestfs.git;a=blob;f=perl/lib/Sys/Guestfs/Lib.pm;h=393eb8adb21dd4e3d40f4394a717f0d679d1dd3b;hb=HEAD#l486

Version-Release number of selected component (if applicable):

libguestfs in RHEL 6.0

Comment 1 Richard W.M. Jones 2011-03-22 10:34:35 UTC
This was fairly simple to reproduce.  First I installed
Windows 7 on a VM with two virtual disks (12 GB + 512 MB).
After installation I formatted the second small disk.
Then I downloaded Firefox and asked it to install on
to the second drive (E:).  Firefox's installer created
E:\Program Files\...

This broke the core inspection code: it tried to find an
operating system on the second disk (because it thought the
presence of "/Program Files" meant it was a Windows root).
It failed to determine the %SYSTEMROOT% of this second
disk.  The error message was:

# virt-inspector Win7x32TwoDisks
libguestfs: error: cannot resolve Windows %SYSTEMROOT%
virt-inspector: no operating system could be detected inside this disk image.

This may be because the file is not a disk image, or is not a virtual machine
image, or because the OS type is not understood by libguestfs.
[...]


Note You need to log in before you can comment on or make changes to this bug.