Bug 675705

Summary:	Review Request: rubygem-tilt - Generic interface to multiple Ruby template engines
Product:	[Fedora] Fedora	Reporter:	Vít Ondruch <vondruch>
Component:	Package Review	Assignee:	Michal Fojtik <mfojtik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, mfojtik, notting
Target Milestone:	---	Flags:	mfojtik: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-02-10 14:24:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vít Ondruch 2011-02-07 13:18:01 UTC

Spec URL: http://people.redhat.com/vondruch/rubygem-tilt.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-tilt-1.2.2-1.fc14.src.rpm
Description: Generic interface to multiple Ruby template engines

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2766960

Comment 1 Michal Fojtik 2011-02-09 12:02:00 UTC

I'll do review for this package.

Comment 2 Michal Fojtik 2011-02-10 09:24:47 UTC

*    Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification.

OK

*    The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version

OK

*   The package must have a Requires and a BuildRequires on rubygems

OK

*   The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification. For every dependency on a Gem named gemdep, the package must contain a Requires on rubygem(%{gemdep}) with the same version constraints as the Gem

OK


*   The %prep and %build sections of the specfile should be empty.

OK

*   The Gem must be installed into %{gemdir} defined as 

%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)

The install should be performed with the command

gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0}

OK

*   The package must own the following files and directories: 

%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec

OK

REVIEW+

Small notes about spec:

 - Please move %{geminstdir}/test to docs
 - In %check there is pushd but no popd
 - Consider replace %{_bindir}/tilt with %{_bindir}/%{gemname}
 - Consider replace %{geminstdir}/tilt.gemspec with %{geminstdir}/%{gemname}.gemspec
 
Please fix those two before pushing this to GIT.

Comment 3 Vít Ondruch 2011-02-10 09:28:24 UTC

Thank you for your review!

New Package SCM Request
=======================
Package Name: rubygem-tilt
Short Description: Generic interface to multiple Ruby template engines
Owners: vondruch
Branches: 
InitialCC:

Comment 4 Jason Tibbitts 2011-02-10 14:03:02 UTC

Git done (by process-git-requests).

Comment 5 Vít Ondruch 2011-05-09 08:43:28 UTC

*** Bug 646808 has been marked as a duplicate of this bug. ***

Comment 6 Vít Ondruch 2011-06-08 09:48:18 UTC

Package Change Request
======================
Package Name: rubygem-tilt
New Branches: f14
Owners: 
InitialCC:

Comment 7 Gwyn Ciesla 2011-06-08 13:10:03 UTC

Git done (by process-git-requests).

Assuming vondruch should be the owner, not specified.

Comment 8 Fedora Update System 2011-06-08 13:47:30 UTC

rubygem-tilt-1.2.2-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-tilt-1.2.2-2.fc14

Comment 9 Fedora Update System 2011-06-21 17:28:48 UTC

rubygem-tilt-1.2.2-2.fc14 has been pushed to the Fedora 14 stable repository.