Spec URL: http://people.redhat.com/vondruch/rubygem-tilt.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-tilt-1.2.2-1.fc14.src.rpm Description: Generic interface to multiple Ruby template engines Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2766960
I'll do review for this package.
* Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification. OK * The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version OK * The package must have a Requires and a BuildRequires on rubygems OK * The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification. For every dependency on a Gem named gemdep, the package must contain a Requires on rubygem(%{gemdep}) with the same version constraints as the Gem OK * The %prep and %build sections of the specfile should be empty. OK * The Gem must be installed into %{gemdir} defined as %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) The install should be performed with the command gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} OK * The package must own the following files and directories: %{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec OK REVIEW+ Small notes about spec: - Please move %{geminstdir}/test to docs - In %check there is pushd but no popd - Consider replace %{_bindir}/tilt with %{_bindir}/%{gemname} - Consider replace %{geminstdir}/tilt.gemspec with %{geminstdir}/%{gemname}.gemspec Please fix those two before pushing this to GIT.
Thank you for your review! New Package SCM Request ======================= Package Name: rubygem-tilt Short Description: Generic interface to multiple Ruby template engines Owners: vondruch Branches: InitialCC:
Git done (by process-git-requests).
*** Bug 646808 has been marked as a duplicate of this bug. ***
Package Change Request ====================== Package Name: rubygem-tilt New Branches: f14 Owners: InitialCC:
Git done (by process-git-requests). Assuming vondruch should be the owner, not specified.
rubygem-tilt-1.2.2-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-tilt-1.2.2-2.fc14
rubygem-tilt-1.2.2-2.fc14 has been pushed to the Fedora 14 stable repository.