| Summary: | [vdsm] when addNetwork is initiated with invalid bonding options no error is propagated. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | David Naori <dnaori> | ||||
| Component: | vdsm | Assignee: | Erez Shinan <erez> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Kiril Nesenko <knesenko> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 6.0 | CC: | abaron, bazulay, danken, dfediuck, dnaori, hateya, iheim, ilvovsky, mgoldboi, ykaul | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | vdsm-4.9-69.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-12-06 07:07:23 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
In order to report invalid bonding arguments, there has to be a definition of what is a valid bonding argument. You can find them in kernel/Documentation/networking/bonding.txt, but I think vdsm should ask the kernel to verify the options and only report an error if it failed. Verified ic119 vdsm-4.9-70.el6.x86_64 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2011-1782.html |
Created attachment 479049 [details] full vdsm log Description of problem: vdsm dose not report an error when addNetwork is initiated to create a bond interface with invalid argument or non-existent option specified in the "BONDING_OPTS" filed. relevant part of the vdsm log: Thread-42827::DEBUG::2011-02-16 10:00:43,224::clientIF::42::vds::(wrapper) [10.35.116.10]::call addNetwork with ('vlan163', '163', 'bond1', ['eth2', 'eth3'], {'STP': 'no', 'BONDING_OPTS': 'mode=X bond=X'}) {} Thread-42827::DEBUG::2011-02-16 10:00:43,225::clientIF::1249::vds::(addNetwork) addNetwork(vlan163,163,bond1,['eth2', 'eth3'],{'STP': 'no', 'BONDING_OPTS': 'mode=X bond=X'}) Thread-42827::DEBUG::2011-02-16 10:00:43,225::utils::570::Storage.Misc.excCmd::(execCmd) '/usr/bin/sudo -n /usr/share/vdsm/addNetwork vlan163 163 bond1 eth2,eth3 STP=no "BONDING_OPTS=mode=X bond=X"' (cwd None) Thread-42827::DEBUG::2011-02-16 10:00:48,370::utils::570::Storage.Misc.excCmd::(execCmd) SUCCESS: <err> = '/etc/sysconfig/network-scripts/ifup-eth: line 131: echo: write error: Invalid argument\n/etc/sysconfig/network-scripts/ifup-eth: line 131: /sys/class/net/bond1/bonding/bond: No such file or directory\n'; <rc> = 0 Thread-42827::DEBUG::2011-02-16 10:00:48,371::clientIF::47::vds::(wrapper) return addNetwork with {'status': {'message': 'Device eth3 has different MAC address than expected, ignoring.\n/etc/sysconfig/network-scripts/ifup-eth: line 131: echo: write error: Invalid argument\n/etc/sysconfig/network-scripts/ifup-eth: line 131: /sys/class/net/bond1/bonding/bond: No such file or directory\n', 'code': 0}} *vdsm should report an "invalid argument" and "option not found" in this situation. Version-Release number of selected component (if applicable): - vdsm-4.9-48 full vdsm log attached.