Bug 677901 - [vdsm] when addNetwork is initiated with invalid bonding options no error is propagated.
Summary: [vdsm] when addNetwork is initiated with invalid bonding options no error is ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: vdsm
Version: 6.0
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Erez Shinan
QA Contact: Kiril Nesenko
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-16 08:46 UTC by David Naori
Modified: 2014-07-11 00:07 UTC (History)
10 users (show)

Fixed In Version: vdsm-4.9-69.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-06 07:07:23 UTC
Target Upstream Version:


Attachments (Terms of Use)
full vdsm log (524.13 KB, application/octet-stream)
2011-02-16 08:46 UTC, David Naori
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2011:1782 0 normal SHIPPED_LIVE new packages: vdsm 2011-12-06 11:55:51 UTC

Description David Naori 2011-02-16 08:46:11 UTC
Created attachment 479049 [details]
full vdsm log

Description of problem: 
vdsm dose not report an error when addNetwork is initiated to create a bond interface with invalid argument or non-existent option specified in the "BONDING_OPTS" filed.

relevant part of the vdsm log:
Thread-42827::DEBUG::2011-02-16 10:00:43,224::clientIF::42::vds::(wrapper) [10.35.116.10]::call addNetwork with ('vlan163', '163', 'bond1', ['eth2', 'eth3'], {'STP': 'no', 'BONDING_OPTS': 'mode=X bond=X'}) {}
Thread-42827::DEBUG::2011-02-16 10:00:43,225::clientIF::1249::vds::(addNetwork) addNetwork(vlan163,163,bond1,['eth2', 'eth3'],{'STP': 'no', 'BONDING_OPTS': 'mode=X bond=X'})
Thread-42827::DEBUG::2011-02-16 10:00:43,225::utils::570::Storage.Misc.excCmd::(execCmd) '/usr/bin/sudo -n /usr/share/vdsm/addNetwork vlan163 163 bond1 eth2,eth3 STP=no "BONDING_OPTS=mode=X bond=X"' (cwd None)
Thread-42827::DEBUG::2011-02-16 10:00:48,370::utils::570::Storage.Misc.excCmd::(execCmd) SUCCESS: <err> = '/etc/sysconfig/network-scripts/ifup-eth: line 131: echo: write error: Invalid argument\n/etc/sysconfig/network-scripts/ifup-eth: line 131: /sys/class/net/bond1/bonding/bond: No such file or directory\n'; <rc> = 0
Thread-42827::DEBUG::2011-02-16 10:00:48,371::clientIF::47::vds::(wrapper) return addNetwork with {'status': {'message': 'Device eth3 has different MAC address than expected, ignoring.\n/etc/sysconfig/network-scripts/ifup-eth: line 131: echo: write error: Invalid argument\n/etc/sysconfig/network-scripts/ifup-eth: line 131: /sys/class/net/bond1/bonding/bond: No such file or directory\n', 'code': 0}}

*vdsm should report an "invalid argument" and "option not found" in this situation.

Version-Release number of selected component (if applicable):
- vdsm-4.9-48

full vdsm log attached.

Comment 1 Erez Shinan 2011-03-17 16:05:46 UTC
In order to report invalid bonding arguments, there has to be a definition of what is a valid bonding argument.

Comment 2 Dan Kenigsberg 2011-05-05 09:23:22 UTC
You can find them in kernel/Documentation/networking/bonding.txt, but I think vdsm should ask the kernel to verify the options and only report an error if it failed.

Comment 3 Erez Shinan 2011-05-24 13:26:33 UTC
http://gerrit.usersys/#change,462

Comment 5 Kiril Nesenko 2011-05-30 07:29:41 UTC
Verified
ic119
vdsm-4.9-70.el6.x86_64

Comment 6 errata-xmlrpc 2011-12-06 07:07:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2011-1782.html


Note You need to log in before you can comment on or make changes to this bug.