Bug 678625
Summary: | Crashes parsing WPA IE | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Owen Taylor <otaylor> | ||||
Component: | wpa_supplicant | Assignee: | Dan Williams <dcbw> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | rawhide | CC: | alex.williamson, cbm, dcbw, kmcmartin, musus.fedorabugs, vbraun.name | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | wpa_supplicant-0.7.3-9.fc15 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2011-08-03 02:32:43 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Owen Taylor
2011-02-18 16:23:55 UTC
*** Bug 689115 has been marked as a duplicate of this bug. *** Created attachment 491018 [details]
Patch that fixes the D-Bus assertion
OK, had a chance to be back in the same location with the same nearby AP that was feeding the offending data and got annoyed enough to come up with a patch. (Also, with NM 0.9, the crash seems to occur much more frequently and make using the network impossible.)
Here's a patch that fixes the assertion failure and just skips the WPA property that can't be parsed - it's a little ugly - since there are *lots* of code paths in dbus_new_handlers.c that separately could potentially trigger this, I just #defined dbus_message_new_error to a version that doesn't throw the assertion but creates an error message message as best as possible from the result.
It might also be desirable to log in the code that currently does:
DBUS_MESSAGE_TYPE_ERROR) {
dbus_message_unref(reply);
continue;
}
in fill_dict_with_properties(), but on the other hand, that's going to result in a lot of log traffic if a parsing error is encountered so I just left it as is. (The downside of not logging, is that if you actually have problems parsing the data provided by the AP you *do* want to connect to, then that's going to be hard to debug.)
I haven't investigated the problem with WPA IE parsing - but this (or a cleaner version) is separately right.
wpa_supplicant-0.7.3-8.fc15 Seems to have fixed it for me! Thanks so much. Push to updates? (I found this issue difficult to track down to this bug) I had a similar issue. Tried out wpa_supplicant-0.7.3-8.fc15, and it fixes it for me to. Thanks! I had the same WiFi issue at one location. Updating to wpa_supplicant-0.7.3-8 fixed it. For some reason its not in updates-testing?! I've just upgraded to F15 and hit this problem and similarly tracked it down to trying to trying to report invalid WPA IE when the message pointer is NULL before finding this... Patched locally, but an official update would be nice. wpa_supplicant-0.7.3-9.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/wpa_supplicant-0.7.3-9.fc15 wpa_supplicant-0.7.3-9.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/wpa_supplicant-0.7.3-9.fc16 Package wpa_supplicant-0.7.3-9.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing wpa_supplicant-0.7.3-9.fc15' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/wpa_supplicant-0.7.3-9.fc15 then log in and leave karma (feedback). wpa_supplicant-0.7.3-9.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. wpa_supplicant-0.7.3-9.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |