Bug 678678
| Summary: | Review Request: rubygem-vte - Ruby binding of vte | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
| Component: | Package Review | Assignee: | Vít Ondruch <vondruch> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, vondruch |
| Target Milestone: | --- | Flags: | vondruch:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-21 17:26:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mamoru TASAKA
2011-02-18 20:49:30 UTC
http://mtasaka.fedorapeople.org/Review_request/rubygem-vte/rubygem-vte-0.90.8-1.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/rubygem-vte/rubygem-vte.spec * Thu Mar 10 2011 Mamoru Tasaka <mtasaka> - 0.90.8-1 - 0.90.8 Taking this one for review. * Installation original gem
- This is apparently upstream bug, comparing the 'vte-0.90.8/ext/vte/depend'
with the 'gtksourceview2-0.90.8/ext/gtksourceview2/depend', which I reviewed
for you previously. So I am wondering if this bug is reported upstream?
- This gem repackaging stuff seems to me pretty ugly. I would suggest the other
way around, i.e. install the gem without the '--with-pkg-config-dir' which is
working just fine and later move the generated ruby-vte.pc into appropriate
place. Or is there something I am missing?
* gtk2 dependency
- Upstream specifies gtk2 >= 0.90.8 runtime dependency while you allow
dependency on 0.90.7. I just want to ensure that this is intentional,
not by mistake.
* rpmlint output:
- rubygem-vte.src: W: strange-permission vte-0.90.8.gem 0600L
Thank you for comments. Will check in a few days. (Update: I am now checking the change on rubygem-rake on F-15 (made by me... )) Updated: http://mtasaka.fedorapeople.org/Review_request/rubygem-vte/rubygem-vte-0.90.8-2.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/rubygem-vte/rubygem-vte.spec * Sun Mar 20 2011 Mamoru Tasaka <mtasaka> - 0.90.8-2 - Some cleanups Looks good now => APPROVED Thank you! New Package SCM Request ======================= Package Name: rubygem-vte Short Description: Ruby binding of vte Owners: mtasaka Branches: f15 f14 Git done (by process-git-requests). Built, push request submitted. Thank you for the review and git procedure, closing. |