Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-vte/rubygem-vte.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-vte/rubygem-vte-0.90.7-2.fc.src.rpm Description: Ruby/VTE is a Ruby binding of VTE Koji scratch build for F-15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2849714 for F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2849717
http://mtasaka.fedorapeople.org/Review_request/rubygem-vte/rubygem-vte-0.90.8-1.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/rubygem-vte/rubygem-vte.spec * Thu Mar 10 2011 Mamoru Tasaka <mtasaka> - 0.90.8-1 - 0.90.8
Taking this one for review.
* Installation original gem - This is apparently upstream bug, comparing the 'vte-0.90.8/ext/vte/depend' with the 'gtksourceview2-0.90.8/ext/gtksourceview2/depend', which I reviewed for you previously. So I am wondering if this bug is reported upstream? - This gem repackaging stuff seems to me pretty ugly. I would suggest the other way around, i.e. install the gem without the '--with-pkg-config-dir' which is working just fine and later move the generated ruby-vte.pc into appropriate place. Or is there something I am missing? * gtk2 dependency - Upstream specifies gtk2 >= 0.90.8 runtime dependency while you allow dependency on 0.90.7. I just want to ensure that this is intentional, not by mistake. * rpmlint output: - rubygem-vte.src: W: strange-permission vte-0.90.8.gem 0600L
Thank you for comments. Will check in a few days.
(Update: I am now checking the change on rubygem-rake on F-15 (made by me... ))
Updated: http://mtasaka.fedorapeople.org/Review_request/rubygem-vte/rubygem-vte-0.90.8-2.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/rubygem-vte/rubygem-vte.spec * Sun Mar 20 2011 Mamoru Tasaka <mtasaka> - 0.90.8-2 - Some cleanups
Looks good now => APPROVED
Thank you! New Package SCM Request ======================= Package Name: rubygem-vte Short Description: Ruby binding of vte Owners: mtasaka Branches: f15 f14
Git done (by process-git-requests).
Built, push request submitted. Thank you for the review and git procedure, closing.