Bug 678910 (activitymanager)
| Summary: | Review Request: kde-plasma-activitymanager - KDE plasma activity manager applet | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Magnus Tuominen <magnus.tuominen> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alekcejk, fedora-package-review, kevin, notting, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | kde-plasma-activitymanager-0.5-2.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-05-24 18:12:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Magnus Tuominen
2011-02-20 18:17:02 UTC
kde-plasma- prefix used by convention for all plasma applets
So kde-plasma-activitymanager will be more more correct name.
No need to run desktop-file-validate for files in %{_datadir}/kde4/services/
%{buildroot} and $RPM_BUILD_ROOT should not be mixed in one spec.
Why you added explicit Requires: kdebase-workspace ?
Thanks for the comments, fixed build and spec: BR changed to kdeplasma-addons-devel and Requires removed. http://magnu5.fedorapeople.org/review/kde-plasma-activitymanager/SPECS/kde-plasma-activitymanager.spec http://magnu5.fedorapeople.org/review/kde-plasma-activitymanager/SRPMS/kde-plasma-activitymanager-0.5-2.fc14.src.rpm rpmlint -iv kde-plasma-activitymanager.spec kde-plasma-activitymanager.spec: I: checking-url http://kde-apps.org/CONTENT/content-files/136278-activitymanager-0.5.tar.bz2 (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -iv kde-plasma-activitymanager-0.5-2.fc14.src.rpm kde-plasma-activitymanager.src: I: checking kde-plasma-activitymanager.src: W: spelling-error %description -l en_US plasmoid -> plasmid, plasmodium, plasmolytic The value of this tag appears to be misspelled. Please double-check. kde-plasma-activitymanager.src: I: checking-url http://kde-apps.org/content/show.php?content=136278 (timeout 10 seconds) kde-plasma-activitymanager.src: I: checking-url http://kde-apps.org/CONTENT/content-files/136278-activitymanager-0.5.tar.bz2 (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. naming: ok sources: ok $ md5sum *.bz2 7592bf60fafcb465fe75cd987a037ffc 136278-activitymanager-0.5.tar.bz2 builds/installs: ok licensing: ok , though looking through the sources looks like GPLv2+ scriptlets: n/a Otherwise fairly small and simple, looks good. APPROVED. New Package SCM Request ======================= Package Name: kde-plasma-activitymanager Short Description: KDE plasma activity manager applet Owners: magnu5 Branches: f14 f15 devel InitialCC: Git done (by process-git-requests). kde-plasma-activitymanager-0.5-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/kde-plasma-activitymanager-0.5-2.fc14 kde-plasma-activitymanager-0.5-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/kde-plasma-activitymanager-0.5-2.fc15 kde-plasma-activitymanager-0.5-2.fc15 has been pushed to the Fedora 15 stable repository. kde-plasma-activitymanager-0.5-2.fc14 has been pushed to the Fedora 14 stable repository. kde-plasma-activitymanager-0.5-2.fc14 has been pushed to the Fedora 14 stable repository. |