Bug 679223

Summary:	installer overwrites all new device passphrases with first-specified/global passphrase
Product:	[Fedora] Fedora	Reporter:	David Lehman <dlehman>
Component:	anaconda	Assignee:	David Lehman <dlehman>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	15	CC:	anaconda-maint-list, jlaska, jonathan, tsukebumi, vanmeeuwen+fedora
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	AcceptedBlocker
Fixed In Version:	anaconda-15.22-1.fc15	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	679166
Clones:	679224 (view as bug list)		Environment:
Last Closed:	2011-03-16 04:06:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	657618, 679224

Description David Lehman 2011-02-21 23:02:07 UTC

+++ This bug was initially created as a clone of Bug #679166 +++

Description of problem:
Documentation for kickstart configuration for partitions says there is a --passphrase parameter to specify each partition's passphrase.
However after installation all partitions are mounted with the same passphrase as if it was a global default

Version-Release number of selected component (if applicable):
pykickstart 1.77-2
anaconda 13.22-1

How reproducible:

always

Steps to Reproduce:
1. Create a kickstart configuration file with a set of partitions where at least two are encrypted and define a different passphrase
2. make an unattended installation with said kickstart

  
Actual results:
At boot, there is a password prompt for mounting a partition. If entered correctly, all partitions are mounted and boot process continiues.

Expected results:
It should be needed to enter all passphrases in order to continue.


Additional info:

--- Additional comment from tsukebumi on 2011-02-21 14:26:18 EST ---

Created attachment 479981 [details]
example kickstart file

--- Additional comment from clumens on 2011-02-21 16:46:59 EST ---

*** Bug 679165 has been marked as a duplicate of this bug. ***

--- Additional comment from dlehman on 2011-02-21 17:50:31 EST ---

Created attachment 480014 [details]
f14 updates to not overwrite passphrases with first/global passphrase

Place the attached updates.img file in os/images/ in your install directory to get it picked up and used automatically. We don't do official fixes for the installer for Fedora 14 after the initial release, but this updates image should fix the problem you have seen.

Let me know if this doesn't solve your problem.

Comment 1 David Lehman 2011-02-21 23:07:12 UTC

If a user creates multiple encrypted devices in kickstart, the first passphrase we find becomes the default/global passphrase in case any other encrypted devices have no passphrase specified. We are erroneously overwriting all devices' passphrases with the global/default when we should only be apply the default to those devices for which no passphrase has been set.

Similarly, if multiple encrypted devices are created in the GUI and a global passphrase is established by the user after having specified passphrases for some newly encrypted devices we should only use the global passphrase for that and subsequent devices instead of overwriting the passphrases already established for previously-created devices.

Comment 2 David Lehman 2011-02-23 03:03:31 UTC

Fixed on master branch (commit e1956392c441a), just awaiting approval to push to f15-branch.

Comment 3 David Lehman 2011-03-09 19:07:40 UTC

Fixed for Fedora 15 in anaconda-15.22-1.

Comment 4 Fedora Update System 2011-03-09 21:54:59 UTC

anaconda-15.22-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/anaconda-15.22-1.fc15

Comment 5 James Laska 2011-03-11 19:40:32 UTC

Discussed at 2011-03-11 blocker review meeting.  This issue is fixed and available for testing in anaconda-15.22-1.  The issue has been accepted as a beta blocker.

Comment 6 Fedora Update System 2011-03-16 04:05:39 UTC

anaconda-15.22-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.