Bug 681003

THis seems more like a lorax issue.  Reassigning.

This means you don't have anaconda package installed in the installtree. Maybe it's missing from the repo?

$ rpm -q pungi anaconda lorax
pungi-2.5-2.fc15.noarch
anaconda-16.1-1.fc16.x86_64
lorax-0.3-3.1.fc16.noarch

All clean (sez "rpm -V")

$ locate lang-table
/usr/share/anaconda/lang-table

(In reply to comment #2)
> This means you don't have anaconda package installed in the installtree. Maybe
> it's missing from the repo?

Hum... in rawhide/Fedora/x86_64/os/Packages/ under the directory where I ran pungi there is no anaconda package. Is that what you mean?

You definitely need anaconda in one of the repos listed in your kickstart file, as lorax will look for it:

share/ramdisk.ltmpl:## anaconda package
share/ramdisk.ltmpl:install "anaconda"

Then pungi didn't pull it down. The file .../logs/Fedora.x86_64.log doesn't mention anaconda, and doesn't complain it isn't there:

# grep '\(ERROR\|WARNING\)' logs/Fedora.x86_64.log
Pungi.ERROR: Group @chinese-support not found in comps!
Pungi.WARNING: Could not find a match for systemd-sysvinit in any configured repo
Pungi.WARNING: Could not find a match for swfdec in any configured repo
Pungi.WARNING: Could not find a match for xfwm4-theme-nodoka in any configured repo
Pungi.WARNING: Could not find a match for s390utils in any configured repo
Pungi.WARNING: Could not find a match for prctl in any configured repo
Pungi.WARNING: Could not find a match for silo in any configured repo
Pungi.WARNING: Could not find a match for xfwm4 in any configured repo
Pungi.WARNING: Unresolvable dependency libcelt0.so.1()(64bit) in gstreamer-plugins-bad-free.x86_64
Pungi.WARNING: Unresolvable dependency libtelepathy-logger.so.1()(64bit) in empathy.x86_64
Pungi.WARNING: Unresolvable dependency libfolks.so.20()(64bit) in empathy.x86_64
Pungi.WARNING: Unresolvable dependency libfolks-telepathy.so.20()(64bit) in empathy.x86_64
Pungi.WARNING: Unresolvable dependency libcelt0.so.1()(64bit) in gstreamer-plugins-bad-free.x86_64
Pungi.WARNING: Unresolvable dependency xfwm4 in xfdesktop.x86_64
Pungi.WARNING: Unresolvable dependency xfwm4 in xfce-utils.x86_64
Pungi.WARNING: Unresolvable dependency xfwm4 in xfdesktop.x86_64
Pungi.WARNING: Unresolvable dependency xserver-abi(videodrv-9) in xorg-x11-drv-openchrome.x86_64
Pungi.WARNING: Unresolvable dependency xserver-abi(videodrv-9) in xorg-x11-drv-qxl.x86_64
Pungi.WARNING: Unresolvable dependency xserver-abi(videodrv-9) in xorg-x11-drv-openchrome.x86_64
Pungi.WARNING: Unresolvable dependency libcelt0.so.1()(64bit) in gstreamer-plugins-bad-free.x86_64
Pungi.WARNING: Unresolvable dependency xserver-abi(videodrv-9) in xorg-x11-drv-qxl.x86_64

Just tried again, now with --releasever 15; still didn't get anaconda (it is currently downloading packages in alphabetic order, AFAICS).

Finished running pungi under Fedora rawhide for release 15: Again failure due to missing anaconda. 

# grep anaconda /usr/share/lorax/ramdisk.ltmpl
## anaconda package
install "anaconda"
remove "anaconda" "/etc/*"
remove "anaconda" "/usr/bin/*"
remove "anaconda" "/usr/share/applications/*"
remove "anaconda" "/usr/share/icons/*"

Either I'm missing something big, or you'll be in a world of hurt composing Fedora on Fedora...

(In reply to comment #5)
> (In reply to comment #2)
> > This means you don't have anaconda package installed in the installtree. Maybe
> > it's missing from the repo?
> 
> Hum... in rawhide/Fedora/x86_64/os/Packages/ under the directory where I ran
> pungi there is no anaconda package. Is that what you mean?

Yes, that's what I mean. You absolutely need anaconda package to make a compose. If it is not in the repo, the repo is broken/not up-to-date, or anaconda is temporarily unavailable. From the pungi log you obviously have also some unresolvable dependency problems, so other packages are missing too.

What repos are you using?

(In reply to comment #10)
 
> What repos are you using?

The ones configured by default for rawhide... I'm _not_ changing anything in the shipped .ks file (the repos are mentioned in there, aren't they?), nor have I tampered with the .repo files for my reports above.

BTW, I did install anaconda, pungi, lorax et al here for rawhide (~~-> 16) with exactly the same configurations.

(In reply to comment #10)
> (In reply to comment #5)
> > (In reply to comment #2)
> > > This means you don't have anaconda package installed in the installtree. Maybe
> > > it's missing from the repo?
> > 
> > Hum... in rawhide/Fedora/x86_64/os/Packages/ under the directory where I ran
> > pungi there is no anaconda package. Is that what you mean?
> 
> Yes, that's what I mean. You absolutely need anaconda package to make a
> compose. If it is not in the repo, the repo is broken/not up-to-date, or
> anaconda is temporarily unavailable. 

There is no mention of anaconda at all in the logs (not that it tried to get it and didn't), except for the lang-table error at the very end.

>                                      From the pungi log you obviously have also
> some unresolvable dependency problems, so other packages are missing too.

Rawhide/16 mess, I suppose. I tried with "--ver 15", there are no ERROR/WARNINGs there. It exits at the end with the same "no lang-table" error, no mention of anaconda otherwise in the log.

Please attach the whole log.

I don't think this is a pungi problem.  If you check out the results of:

        template = template.parse(tfile, tvars)

from pylorax/__init__.py, you'll see that template[0] is:

(Pdb) print template[0]
['i\x00\x00\x00n\x00\x00\x00s\x00\x00\x00t\x00\x00\x00a\x00\x00\x00l\x00\x00\x00l\x00\x00\x00', '\x00\x00\x00\x00\x00\x00a\x00\x00\x00n\x00\x00\x00a\x00\x00\x00c\x00\x00\x00o\x00\x00\x00n\x00\x00\x00d\x00\x00\x00a\x00\x00\x00\x00\x00\x00']

I think something strange is going on with the lorax/mako interaction.

The problem area in question in in pylorax/ltmpl.py:

 48  	        # split, strip and remove empty lines
 49  	        lines = textbuf.splitlines()
 50  	        lines = map(lambda line: line.strip(), lines)
 51  	        lines = filter(lambda line: line, lines)
 52  	
 53  	        # split with shlex
 54  	        lines = map(shlex.split, lines)

After line 51, lines is a list of unicode text.  shlex.split does not do well with that as input (see http://bugs.python.org/issue6988).  So, at the least, each element of lines needs to be converted to a regular string before calling split.  There are other possible fixes.

Created attachment 482787 [details]
Logfile with "--ver rawhide"

Created attachment 482788 [details]
With "--ver 15"

Created attachment 482790 [details]
Using "/usr/share/pungi/rawhide-fedora.ks", no --ver

Fixed in lorax-0.4-1

(In reply to comment #19)
> Fixed in lorax-0.4-1

For ~~-> 16 only?

Hi, I need a blocker to push this to F15 now

This should not be a problem in F15, rawhide has a newer python-mako package, the old one does not require this patch.

This problem is back in Fedora 16:


# rpm -q pungi anaconda lorax
pungi-2.9-1.fc16.noarch
anaconda-16.25-1.fc16.i686
lorax-16.4.7-2.fc16.i686

...
(507/514) [100%] installing rdate-1.4-17.fc15.i686
(508/514) [100%] installing 2:reiserfs-utils-3.6.21-4.fc15.i686
(509/514) [100%] installing 2:ntfs-3g-2011.4.12-5.fc16.i686
(510/514) [100%] installing hdparm-9.36-2.fc15.i686
(511/514) [100%] installing strace-4.6-1.fc16.i686
(512/514) [100%] installing 2:ethtool-2.6.39-1.fc16.i686
(513/514) [100%] installing rsh-0.17-65.fc15.i686
(514/514) [100%] installing vconfig-1.9-9.fc15.i686
writing .buildstamp file
removing locales
could not find anaconda lang-table, exiting

I am still getting this error for F17, F18 and Rawhide even though anaconda and lorax are in x86_64/os/Packages/ and there are lines 53/54 in 
/usr/lib/python2.7/site-packages/pylorax/ltmpl.py :

 # mako template now returns unicode strings
 lines = map(lambda line: line.encode("ascii"), lines)

before lines:

 # split with shlex
 lines = map(shlex.split, lines)

Surely there must be a real fix by now?

Thanks,

Phil.