Bug 681078

Summary:	Need input 'quit' twice to quit ncftool interactive terminal
Product:	Red Hat Enterprise Linux 6	Reporter:	zhanghaiyan <yoyzhang>
Component:	netcf	Assignee:	Laine Stump <laine>
Status:	CLOSED ERRATA	QA Contact:	qe-baseos-daemons
Severity:	low	Docs Contact:
Priority:	low
Version:	6.1	CC:	dallan, dyuan, llim, vbian
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	netcf-0.1.9-1.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-06 15:18:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description zhanghaiyan 2011-03-01 03:06:54 UTC

Description of problem:
Need input 'quit' twice to quit ncftool interactive terminal when previous command returns false

Version-Release number of selected component (if applicable):
- kernel-2.6.32-117.el6.x86_64
- netcf-0.1.7-1.el6.x86_64

How reproducible:
always

Steps to Reproduce:
1.# ncftool 
ncftool> cd
Unknown command 'cd'
ncftool> quit
ncftool> quit
[root@dhcp-65-132 ~]# 
  
Actual results:
Need input 'quit' twice to quit interactive terminal, it seems it has some relationship with the previous command return value

Expected results:
quit once

Additional info:

Comment 2 RHEL Program Management 2011-04-04 02:10:08 UTC

Since RHEL 6.1 External Beta has begun, and this bug remains
unresolved, it has been rejected as it is not proposed as
exception or blocker.

Red Hat invites you to ask your support representative to
propose this request, if appropriate and relevant, in the
next release of Red Hat Enterprise Linux.

Comment 3 Laine Stump 2011-05-18 17:39:11 UTC

A fix has been committed to upstream netcf, and will be included when RHEL
netcf is rebased (see Bug 705061):

commit ce8270a336222816f907adc84cbdc322a82f0970
Author: Laine Stump <laine>
Date:   Wed May 11 22:45:23 2011 -0400

    ncftool: Don't require "quit" command twice after a failed command
    
    This is in response to: https://bugzilla.redhat.com/show_bug.cgi?id=681078
    
    If an invalid command was entered at the ncftool prompt, and then
    "quit" was immediately issued, it would be ignored - a 2nd "quit"
    would be needed to exit from ncftool.
    
    This was caused by main_loop() checking the wrong return status when
    deciding to exit. Rather than checking the status of the command that
    was just run, it was looking of the status of the command just prior
    to that, and only exiting if that command was successful. What was
    needed was to check the return status of the "quit" command (which
    currently is always 0, but I suppose may change in the future.)

Comment 4 Laine Stump 2011-06-14 21:36:56 UTC

A fix for this bug is included in netcf-0.1.8-1.el6. A build is available here:

https://brewweb.devel.redhat.com/buildinfo?buildID=167451

Comment 6 Vivian Bian 2011-08-04 06:57:53 UTC

tested with netcf-0.1.9-1.el6

Steps:
# ncftool 
ncftool> cd 
Unknown command 'cd'
ncftool> quit
# 

to quit ncftool interactive terminal , you only input 'quit' once 

So set bug status to VERIFIED

Comment 7 errata-xmlrpc 2011-12-06 15:18:55 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1631.html