Bug 681499
| Summary: | Duplicate blocks in targets.conf result in error: "Not a HASH reference at /usr/sbin/tgt-admin line 266." | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Lubos Kocman <lkocman> | ||||
| Component: | scsi-target-utils | Assignee: | Andy Grover <agrover> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Storage QE <storage-qe> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 6.0 | CC: | bdonahue, coughlan, mchristi | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-10-04 22:44:34 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Caused by duplicate targets (one of them was populated one empty see attachment). Is it still a bug? Created attachment 483002 [details]
proposed fix
I'm not a perl expert but it seems like the right thing to do is to merge duplicate blocks when reading targets.conf. Please try this patch.
|
Created attachment 481844 [details] targets.conf Description of problem: restarting of tgtd raises warning: Not a HASH reference at /usr/sbin/tgt-admin line 266. Version-Release number of selected component (if applicable): scsi-target-utils-1.0.4-3.el6.x86_64 How reproducible: Steps to Reproduce: 1. sudo service tgtd reload 2. sudo service tgtd force-restart 3. Actual results: Force-stopping SCSI target daemon: [ OK ] Starting SCSI target daemon: [ OK ] Not a HASH reference at /usr/sbin/tgt-admin line 266. Expected results: Force-stopping SCSI target daemon: [ OK ] Starting SCSI target daemon: [ OK ] Additional info: head -266 /usr/sbin/tgt-admin | tail -1 foreach my $k3 (sort keys %{$conf{$k}{$k2}}) { md5sum /usr/sbin/tgt-admin 0f93e1ae6e346f0cca3319c7edab7b00 /usr/sbin/tgt-admin