Bug 681499 - Duplicate blocks in targets.conf result in error: "Not a HASH reference at /usr/sbin/tgt-admin line 266."
Summary: Duplicate blocks in targets.conf result in error: "Not a HASH reference at /u...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: scsi-target-utils
Version: 6.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Andy Grover
QA Contact: Storage QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-02 11:44 UTC by Lubos Kocman
Modified: 2011-10-04 22:44 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-10-04 22:44:34 UTC
Target Upstream Version:

Attachments (Terms of Use)
proposed fix (1.03 KB, patch)
2011-03-08 19:53 UTC, Andy Grover 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Lubos Kocman 2011-03-02 11:44:28 UTC 
Created attachment 481844 [details]
targets.conf

Description of problem:

restarting of tgtd raises warning:

Not a HASH reference at /usr/sbin/tgt-admin line 266.

Version-Release number of selected component (if applicable):

scsi-target-utils-1.0.4-3.el6.x86_64


How reproducible:


Steps to Reproduce:
1. sudo service tgtd reload
2. sudo service tgtd force-restart
3.
  
Actual results:

Force-stopping SCSI target daemon:                         [  OK  ]
Starting SCSI target daemon:                               [  OK  ]
Not a HASH reference at /usr/sbin/tgt-admin line 266.


Expected results:

Force-stopping SCSI target daemon:                         [  OK  ]
Starting SCSI target daemon:                               [  OK  ]

Additional info:


head -266 /usr/sbin/tgt-admin | tail -1
					foreach my $k3 (sort keys %{$conf{$k}{$k2}}) {


md5sum /usr/sbin/tgt-admin
0f93e1ae6e346f0cca3319c7edab7b00  /usr/sbin/tgt-admin
Comment 1 Lubos Kocman 2011-03-02 12:45:35 UTC 
Caused by duplicate targets (one of them was populated one empty see attachment). Is it still a bug?
Comment 2 Andy Grover 2011-03-08 19:53:12 UTC 
Created attachment 483002 [details]
proposed fix

I'm not a perl expert but it seems like the right thing to do is to merge duplicate blocks when reading targets.conf. Please try this patch.
Note You need to log in before you can comment on or make changes to this bug.