Bug 681567

Summary: rpm should warn about unclosed macros
Product: [Fedora] Fedora Reporter: Mike McLean <mikem>
Component: rpmAssignee: Panu Matilainen <pmatilai>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 14CC: ffesti, jnovy, mtasaka, pmatilai
Target Milestone: ---Keywords: Upstream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-07-19 09:08:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
example spec file none

Description Mike McLean 2011-03-02 15:38:56 UTC
Created attachment 481886 [details]
example spec file

Description of problem:
An unclosed macro can cause a build to fail, or more insidiously, build incompletely without any sort of warning.

Version-Release number of selected component (if applicable):
rpm-4.8.1-5.fc14.x86_64
(but the problem goes way back)

How reproducible:
100%

Steps to Reproduce:
1. rpmbuild -ba fake.spec  [attached]

Actual results:
there are no build errors or warnings, but only an srpm is written

Expected results:
rpm should warn about such syntax errors.


Additional info:
see also: bug 184196

Comment 1 Panu Matilainen 2011-05-12 09:31:46 UTC
*** Bug 632862 has been marked as a duplicate of this bug. ***

Comment 2 Panu Matilainen 2011-06-16 16:32:17 UTC
Fixed upstream...

Comment 3 Panu Matilainen 2011-07-19 09:08:59 UTC
This is fixed in rpm >= 4.9.1, now in rawhide. F15 will get this too sooner than later but backport to rpm 4.8.x is not planned at this point, so closing -> RAWHIDE. This is the new behavior:

[pmatilai@turre ~]$ rpmbuild -bb ~/Download/fake.spec
error: line 12: unclosed macro or bad line continuation