Bug 681567 - rpm should warn about unclosed macros
Summary: rpm should warn about unclosed macros
Alias: None
Product: Fedora
Classification: Fedora
Component: rpm
Version: 14
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Panu Matilainen
QA Contact: Fedora Extras Quality Assurance
: 632862 (view as bug list)
Depends On:
TreeView+ depends on / blocked
Reported: 2011-03-02 15:38 UTC by Mike McLean
Modified: 2011-07-19 09:08 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2011-07-19 09:08:59 UTC
Type: ---

Attachments (Terms of Use)
example spec file (485 bytes, application/octet-stream)
2011-03-02 15:38 UTC, Mike McLean
no flags Details

Description Mike McLean 2011-03-02 15:38:56 UTC
Created attachment 481886 [details]
example spec file

Description of problem:
An unclosed macro can cause a build to fail, or more insidiously, build incompletely without any sort of warning.

Version-Release number of selected component (if applicable):
(but the problem goes way back)

How reproducible:

Steps to Reproduce:
1. rpmbuild -ba fake.spec  [attached]

Actual results:
there are no build errors or warnings, but only an srpm is written

Expected results:
rpm should warn about such syntax errors.

Additional info:
see also: bug 184196

Comment 1 Panu Matilainen 2011-05-12 09:31:46 UTC
*** Bug 632862 has been marked as a duplicate of this bug. ***

Comment 2 Panu Matilainen 2011-06-16 16:32:17 UTC
Fixed upstream...

Comment 3 Panu Matilainen 2011-07-19 09:08:59 UTC
This is fixed in rpm >= 4.9.1, now in rawhide. F15 will get this too sooner than later but backport to rpm 4.8.x is not planned at this point, so closing -> RAWHIDE. This is the new behavior:

[pmatilai@turre ~]$ rpmbuild -bb ~/Download/fake.spec
error: line 12: unclosed macro or bad line continuation

Note You need to log in before you can comment on or make changes to this bug.