Bug 682300

Summary:	dbus-activated app widgets unthemed
Product:	[Fedora] Fedora	Reporter:	Rex Dieter <rdieter>
Component:	kdelibs	Assignee:	Than Ngo <than>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	14	CC:	balajig81, jreznik, kevin, ltinkl, rdieter, rhughes, rnovacek, ry, smparrish, than
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	kdelibs-4.6.1-4.fc15	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-03-16 04:05:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	657002

Description Rex Dieter 2011-03-04 19:38:50 UTC

Since kde-4.6.1, kpackagekitsmarticon update notifier is using ugly fallback qt (motify) theme, seemingly not using oxygen (via kde platform plugin).

Comment 1 Kevin Kofler 2011-03-06 09:23:53 UTC

I found the offending commit (to kde-workspace/kcontrol/krdb):
https://projects.kde.org/projects/kde/kdebase/kde-workspace/repository/revisions/9d7eb8f716873d2079039d336c8f9a21b2fae0fa
and followup:
https://projects.kde.org/projects/kde/kdebase/kde-workspace/repository/revisions/da97a77fcd01892a7e2a1a4e8e71ab94b2ece32f

This breaks because KPK is D-Bus-activated, so it gets D-Bus's environment, which doesn't have QT_PLUGIN_PATH set. It was previously getting the plugin path set from that krdb code.

I see 2 possible fixes:
A. Revert these changes, making sure we get the kconf_update stuff right.
B. Changing kpackagekitsmarticon to be a KApplication.

Note that only Qt-only apps which are D-Bus-activated are affected by the change.

Comment 2 Kevin Kofler 2011-03-06 09:25:53 UTC

On one hand, I feel tempted to do A because this is an incompatible change in a point release, but on the other hand, B is probably the better/upstreamable fix. kpackagekitsmarticon really shouldn't be Qt-only.

Comment 3 Kevin Kofler 2011-03-06 10:00:55 UTC

Reproducible: Always

Steps to Reproduce:
1. Wait for KPackageKit to check for updates.
2. Notice the D-Bus-activated kpackagekitsmarticon showing up.
3. Click on the system tray icon.

Actual Results:  
The GUI pops up in Qt's ugly default theme.

Expected Results:  
The GUI pops up in the theme selected in KDE, i.e. usually Oxygen.

This is a regression when updating the KDE Plasma workspace(s) from 4.6.0 to
4.6.1.


Submitted upstream: https://bugs.kde.org/show_bug.cgi?id=267770

Comment 4 Kevin Kofler 2011-03-06 20:30:38 UTC

Actually, kpackagekitsmarticon is already a KUniqueApplication (i.e. a KApplication subclass), yet we still end up with the theme not getting found.

KApplication doesn't set the plugin path, it expects it to be already set. It does try to set the default theme, but that doesn't help if Qt doesn't find it.

So there's no easy/good fix for this within KPackageKit, it needs to be fixed inside kdelibs (KApplication) or kde-workspace (krdb, by reverting the offending change).

Comment 5 Fedora Update System 2011-03-11 04:40:45 UTC

kdelibs-4.6.1-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/kdelibs-4.6.1-3.fc15

Comment 6 Rex Dieter 2011-03-11 12:51:37 UTC

My first test was to run dragon, and wait for kpk to prompt to install missing codecs, fail.  that dialog was still unthemed.  :(

Comment 7 Rex Dieter 2011-03-11 15:17:06 UTC

confirmed now that kpackagekitsmarticon theming isn't fixed either.

Comment 8 Rex Dieter 2011-03-11 15:32:37 UTC

Re-assigning and adjusting summary.

Comment 9 Fedora Update System 2011-03-16 04:05:08 UTC

kdelibs-4.6.1-4.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.