Bug 682373

Summary:	linux net event code is... bad
Product:	[Fedora] Fedora	Reporter:	Bill Nottingham <notting>
Component:	papi	Assignee:	William Cohen <wcohen>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	15	CC:	rvokal, wcohen
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	682374 (view as bug list)		Environment:
Last Closed:	2011-03-10 21:17:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	682334, 682374

Description Bill Nottingham 2011-03-05 01:27:32 UTC

Description of problem:

1) It hardcodes devices in the ethX space. Network devices can have arbitrary names, and due to http://fedoraproject.org/wiki/Features/ConsistentNetworkDeviceNaming, will have
different names in Fedora 15.

2) It hardcodes the specific device names, such that it will only read 'lo' and 'eth0-4'. What if you have more than five ethernet devices? What if due to hardware changes, you merely have eth4-7?

3) It does all this by popen()ing ifconfig.

I would think this could be made a lot shorter, simpler, and more correct by just opening and reading /proc/net/dev.

Version-Release number of selected component (if applicable):

papi-4.1.2.1

How reproducible:

By visual inspection.

Comment 1 Bill Nottingham 2011-03-08 16:59:59 UTC

Statistics are also in /sys/class/net/<device>/statistics, which is probably even easier to parse.

Comment 2 William Cohen 2011-03-10 19:58:35 UTC

PAPI isn't currently being built with any of the PAPI-C components, so this isn't visible in any of the executables in the package.

Comment 3 Bill Nottingham 2011-03-10 20:05:01 UTC

Hooray... so this can be closed? Or is the plan to enable these at some point?

Comment 4 William Cohen 2011-03-10 21:17:23 UTC

This doesn't yield any problem executables because the PAPI-C components are
not enabled.