Bug 683108

Summary:	System settings not all set in GUI for fresh DB
Product:	[Other] RHQ Project	Reporter:	Jay Shaughnessy <jshaughn>
Component:	Core UI	Assignee:	John Mazzitelli <mazz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Corey Welton <cwelton>
Severity:	low	Docs Contact:
Priority:	medium
Version:	4.0.0.B02	CC:	ian.springer, mazz, mfoley
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	585306

Description Jay Shaughnessy 2011-03-08 15:21:05 UTC

1) -Ddbsetup

2) Start CoreGUI

3) Admin->System Settings

4) Inspect the Yes/No radio box props

5) Try to save a change to, say, Agent suspect down time

For me, this failed and I had to explicitly set all of the Yes/No props.  These should be set to defaults at install time and should not need to be set in the GUI when visiting system settings (of course, they should be able to be changed as desired).

Comment 1 John Mazzitelli 2011-03-08 15:28:32 UTC

we need to look at the data in RHQ_SYSTEM_CONFIG and make sure the values coming out of it and into the radio button components are valid values. If the setValue() values of the radio buttons are what the component wants (non-null Boolean) then it won't render any value and you will be forced to enter one.

Comment 2 John Mazzitelli 2011-03-08 16:09:42 UTC

the problem is enable_debug and enable_experimental settings aren't in rhq_system_config by default. I made the system config view more tolerant in any case where a config setting isn't in the db but we have a default value we can assume.

commit 424ea1880f8897351d70f6f138c27a4b89b89513

Comment 3 Ian Springer 2011-03-10 17:34:29 UTC

With a fresh DB, in addition to the two mentioned above, the following properties were also flagged as invalid when I tried to save the system settings:

Enable Agent Auto-Updates
Reindex Data Tables Nightly

Strangely, they had values (i.e. one of the Yes/No radio buttons was selected), so I'm not sure why they were considered invalid.

Comment 4 John Mazzitelli 2011-03-10 17:38:22 UTC

I'm gonna flip this back to ON_QA and see how testing goes. My fix was general - it should correct any missing props.

Comment 5 Mike Foley 2011-04-20 23:12:58 UTC

this is verified in the 4/29/2011 release testing.

Comment 6 Corey Welton 2011-05-24 01:15:41 UTC

Bookkeeping - closing bug - fixed in recent release.

Comment 7 Corey Welton 2011-05-24 01:15:41 UTC

Bookkeeping - closing bug - fixed in recent release.

Comment 8 Corey Welton 2011-05-24 01:15:43 UTC

Bookkeeping - closing bug - fixed in recent release.

Comment 9 Corey Welton 2011-05-24 01:15:46 UTC

Bookkeeping - closing bug - fixed in recent release.