Bug 683855
| Summary: | gtk unthemed (ugly) when gnome-themes-standard not present | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> | ||||
| Component: | gnome-themes-standard | Assignee: | Cosimo Cecchi <ccecchi> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 15 | CC: | ccecchi, christoph.wickert, jreznik, kevin, mclasen, mgracik | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-04-05 23:02:37 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 617261, 669355, 678917 | ||||||
| Attachments: |
|
||||||
|
Description
Rex Dieter
2011-03-10 14:13:22 UTC
And dragging in gnome-themes-standard as is is not a good idea because that drags in several unwanted dependencies which are not required for GTK+ to work. Created attachment 486339 [details]
Specfile patch
Would the attached patch to the specfile be an acceptable solution?
This moves the GTK+ config files to the GTK+ theme subpackages. Those subpackages are required by gnome-themes-standard, so any installs which get the config files now will still get them dragged in. But with the change, it is enough to ship adwaita-gtk3-theme on a spin to get GTK+ 3 Adwaita-themed.
(FWIW, the gtk-icon-theme-name, gtk-button-images and gtk-menu-images settings should be mostly irrelevant, they will most likely get overridden through xsettings anyway, at least xsettings-kde does that. Only places like firstboot see them at all.)
As a result of bug 675509 the theme was split similar to Kevin's proposal, so I wonder if this is still a problem. Yes. Check my patch in my proposal carefully, it is a followup to the changes from bug #675509. It moves the default GTK+ config files into the adwaita-gtk[23]-theme subpackages introduced by the fix for bug #675509. Ping? Is the specfile patch I attached in comment #2 acceptable? gnome-themes-standard-2.91.93-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/gnome-themes-standard-2.91.93-2.fc15 This "fix" is very wrong! Dragging in gnome-themes-standard from adwaita-cursor-theme defeats the very purpose of the adwaita-cursor-theme split. This is not acceptable. See also the discussion in bug 675509. Package gnome-themes-standard-2.91.93-3.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing gnome-themes-standard-2.91.93-3.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/gnome-themes-standard-2.91.93-3.fc15 then log in and leave karma (feedback). Uh no, gnome-themes-standard-2.91.93-3.fc15 doesn't fix this issue. (The broken "fix" got reverted, but no working one was applied.) What do you think of my suggested fix from comment #2? Kevin, now you're mistaken; your patch was applied indeed. See the spec file at http://pkgs.fedoraproject.org/gitweb/?p=gnome-themes-standard.git;a=tree;h=refs/heads/f15/master;hb=refs/heads/f15/master Oh, indeed it's there, I still can't find the commit that made the change, but it's there. :-) But you will have to file a new update request because the one you edited got unpushed due to bad karma. This is the relevant commit: http://pkgs.fedoraproject.org/gitweb/?p=gnome-themes-standard.git;a=blobdiff;f=gnome-themes-standard.spec;h=a4382263ab60c632a4b173d02187849dca2a8c2a;hp=fbf2177fa8393e6d494cde9e2d21fb9b4b8a677b;hb=909eb90ccc4dfeb4cc5b44dfe1fb6b71f8984b3f;hpb=92edc63ef63f669b2dc55afde0eeadd19a5eb9a4 Filing a new update now. gnome-themes-standard-3.0.0-1.fc15, which includes this fix (among other things) got pushed to F15 stable today and will be included in the F15 Beta. |