Bug 683933

Summary: Async tasks are not auditable
Product: [Retired] Pulp Reporter: Jay Dobies <jason.dobies>
Component: z_otherAssignee: Jason Connor <jconnor>
Status: CLOSED DUPLICATE QA Contact: Preethi Thomas <pthomas>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: mmccune
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 689927 (view as bug list) Environment:
Last Closed: 2011-03-22 19:52:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jay Dobies 2011-03-10 17:32:49 UTC 
Something changed between December and now because this used to work.

When a task is created, it pulls out the name of the function it's going to execute (callable.__name__). If this method is decorated with @audit, this name will be returned as "_audit".

This has the effect that the lookup for tasks by method name, something we do for both repo and CDS syncs, will fail because the method name isn't properly captured.

Repo sync was already unaudited so this isn't an issue there. For now, I removed the audit decorator from CDS sync until this is fixed.
Comment 1 Jay Dobies 2011-03-22 19:17:18 UTC 
There's no direct way to verify this. However, this leads to the bigger issue that CDS and repo syncs aren't audited.

Please file a new bug that those should be audited. That will be able to be verified by just looking at the audit logs. I'll leave it to you to decide what to do about this bug, either close it or make it dependent on the new bug to show this is correctly fixed and allows for CDS/repo sync auditing.
Comment 2 Preethi Thomas 2011-03-22 19:52:44 UTC 
Closing.

*** This bug has been marked as a duplicate of bug 689927 ***