Bug 683933 - Async tasks are not auditable
Summary: Async tasks are not auditable
Keywords:
Status: CLOSED DUPLICATE of bug 689927
Alias: None
Product: Pulp
Classification: Retired
Component: z_other
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Jason Connor
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-10 17:32 UTC by Jay Dobies
Modified: 2014-03-31 01:39 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 689927 (view as bug list)
Environment:
Last Closed: 2011-03-22 19:52:44 UTC

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Jay Dobies 2011-03-10 17:32:49 UTC 
Something changed between December and now because this used to work.

When a task is created, it pulls out the name of the function it's going to execute (callable.__name__). If this method is decorated with @audit, this name will be returned as "_audit".

This has the effect that the lookup for tasks by method name, something we do for both repo and CDS syncs, will fail because the method name isn't properly captured.

Repo sync was already unaudited so this isn't an issue there. For now, I removed the audit decorator from CDS sync until this is fixed.
Comment 1 Jay Dobies 2011-03-22 19:17:18 UTC 
There's no direct way to verify this. However, this leads to the bigger issue that CDS and repo syncs aren't audited.

Please file a new bug that those should be audited. That will be able to be verified by just looking at the audit logs. I'll leave it to you to decide what to do about this bug, either close it or make it dependent on the new bug to show this is correctly fixed and allows for CDS/repo sync auditing.
Comment 2 Preethi Thomas 2011-03-22 19:52:44 UTC 
Closing.

*** This bug has been marked as a duplicate of bug 689927 ***
Note You need to log in before you can comment on or make changes to this bug.