Bug 685014
Summary: | Review Request: perl-Sys-Path - Supply autoconf style installation directories | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ruediger Landmann <rlandman> |
Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-06-09 23:45:39 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ruediger Landmann
2011-03-15 03:58:15 UTC
- rpmlint OK - package must be named according to Guidelines OK - spec file name must match the base package %{name} OK - package must meet the Packaging Guidelines OK - package must be licensed with Fedora approved license OK - license field must match actual license OK - text of the license in its own file must be included in %doc OK - sources must match the upstream source OK - package MUST successfully compile and build OK - architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK - build dependencies must be listed in BuildRequires OK - handle locales properly with %find_lang macro OK - shared library files must call ldconfig in %post(un) OK - packages must NOT bundle system libraries OK - package must own all directories that it creates OK - permissions on files must be set properly OK - package must consistently use macros OK - package must contain code, or permissable content OK - large documentation must go in a -doc OK - %doc must not affect the runtime of the application OK - header files must be in a -devel package OK - static libraries must be in a -static package OK - library files that end in .so (without suffix) must go in a -devel OK - devel package usually require base package OK - packages must NOT contain any .la libtool archives OK - GUI applications must include a %{name}.desktop file OK - packages must not own files or directories already owned by other packages OK rpm -q --provides perl-Sys-Path perl(Sys::Path) = 0.10 perl(Sys::Path::SPc) = 0.10 perl-Sys-Path = 0.10-1.fc16 [marca@caladan SRPMS]$ rpm -q --requires perl-Sys-Path perl(:MODULE_COMPAT_5.12.3) perl(Carp) perl(Digest::MD5) perl(File::Spec) perl(JSON::Util) perl(JSON::Util) perl(List::MoreUtils) perl(List::MoreUtils) perl(Sys::Path::SPc) perl(Text::Diff) perl(Text::Diff) perl(base) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 Specifying requires in spec file is useless, because RPM is able to find it and it's twice in requires. Please remove "doubled" requires. Ping? Sorry Marcela; I seemed to miss the Bugzilla email in March :( I've removed the redundant Requires: and rebuilt the package: new specfile: http://rlandmann.fedorapeople.org/packages/perl-Sys-Path.spec new SRPM: http://rlandmann.fedorapeople.org/packages/perl-Sys-Path-0.10-2.fc14.src.rpm new scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=3121429 Thanks! Rudi deffattr is not needed in latest rpm, but that's not a blocker. APPROVED Thanks Marcela :) New Package SCM Request ======================= Package Name: perl-Sys-Path Short Description: Supply autoconf style installation directories Owners: rlandmann Branches: f14 f15 el6 InitialCC: perl-sig Git done (by process-git-requests). |