Bug 685014 - Review Request: perl-Sys-Path - Supply autoconf style installation directories
Summary: Review Request: perl-Sys-Path - Supply autoconf style installation directories
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-15 03:58 UTC by Ruediger Landmann
Modified: 2011-06-09 23:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-06-09 23:45:39 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Ruediger Landmann 2011-03-15 03:58:15 UTC
Spec URL:
http://rlandmann.fedorapeople.org/packages/perl-Sys-Path.spec

SRPM URL:
http://rlandmann.fedorapeople.org/packages/perl-Sys-Path-0.10-1.fc14.src.rpm

Description:
The goal is that Sys::Path provides autoconf style system paths.

rpmlint output:
$ rpmlint SPECS/perl-Sys-Path.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SRPMS/perl-Sys-Path-0.10-1.fc14.src.rpm
perl-Sys-Path.src: W: spelling-error Summary(en_US) autoconf -> auto conf, auto-conf, autochthon
perl-Sys-Path.src: W: spelling-error %description -l en_US autoconf -> auto conf, auto-conf, autochthon
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint RPMS/noarch/perl-Sys-Path-0.10-1.fc14.noarch.rpm
perl-Sys-Path.noarch: W: spelling-error Summary(en_US) autoconf -> auto conf, auto-conf, autochthon
perl-Sys-Path.noarch: W: spelling-error %description -l en_US autoconf -> auto conf, auto-conf, autochthon
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Scratchbuild in Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2912647

Comment 1 Marcela Mašláňová 2011-03-29 08:29:35 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -q --provides perl-Sys-Path
perl(Sys::Path) = 0.10
perl(Sys::Path::SPc) = 0.10
perl-Sys-Path = 0.10-1.fc16
[marca@caladan SRPMS]$ rpm -q --requires perl-Sys-Path
perl(:MODULE_COMPAT_5.12.3)  
perl(Carp)  
perl(Digest::MD5)  
perl(File::Spec)  
perl(JSON::Util)  
perl(JSON::Util)  
perl(List::MoreUtils)  
perl(List::MoreUtils)  
perl(Sys::Path::SPc)  
perl(Text::Diff)  
perl(Text::Diff)  
perl(base)  
perl(strict)  
perl(warnings)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

Specifying requires in spec file is useless, because RPM is able to find it and it's twice in requires. Please remove "doubled" requires.

Comment 2 Marcela Mašláňová 2011-06-06 14:28:33 UTC
Ping?

Comment 3 Ruediger Landmann 2011-06-09 11:38:30 UTC
Sorry Marcela; I seemed to miss the Bugzilla email in March :(

I've removed the redundant Requires: and rebuilt the package:

new specfile: 
http://rlandmann.fedorapeople.org/packages/perl-Sys-Path.spec

new SRPM:
http://rlandmann.fedorapeople.org/packages/perl-Sys-Path-0.10-2.fc14.src.rpm

new scratchbuild:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3121429

Thanks!
Rudi

Comment 4 Marcela Mašláňová 2011-06-09 13:50:34 UTC
deffattr is not needed in latest rpm, but that's not a blocker.
APPROVED

Comment 5 Ruediger Landmann 2011-06-09 23:05:24 UTC
Thanks Marcela :)

New Package SCM Request
=======================
Package Name: perl-Sys-Path
Short Description: Supply autoconf style installation directories
Owners: rlandmann
Branches: f14 f15 el6
InitialCC: perl-sig

Comment 6 Jason Tibbitts 2011-06-09 23:11:38 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.