Bug 688499

Summary: Review Request: cabal-dev - Haskell package sandboxing tool
Product: [Fedora] Fedora Reporter: Jens Petersen <petersen>
Component: Package ReviewAssignee: Narasimhan <lakshminaras2002>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: bos, fedora-package-review, haskell-devel, lakshminaras2002, notting
Target Milestone: ---Flags: lakshminaras2002: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: cabal-dev-0.8-2.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-08-12 10:52:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 634048    

Description Jens Petersen 2011-03-17 09:11:04 UTC
Spec URL: http://petersen.fedorapeople.org/cabal-dev/cabal-dev.spec
SRPM URL: http://petersen.fedorapeople.org/cabal-dev/cabal-dev-0.7.4.1-1.fc14.src.rpm
Description:
cabal-dev is a tool for managing development builds of Haskell projects.
It supports maintaining sandboxed cabal-install repositories,
and sandboxed ghc package databases.

Comment 1 Jens Petersen 2011-03-17 09:16:48 UTC
Note this package needs Cabal >= 1.10 to build,
ie this package will only be for F15 and later.

It will not build with standard ghc-6.12.x installs
(unless you cabal install Cabal).

Comment 3 Jens Petersen 2011-07-13 08:52:30 UTC
I'd like to ask bos if he is still using this package.
I have only tried lightly a few times but I am not fully convinced yet
if this is really the optimal approach to avoiding cabal breakage.
It may be more useful for developers than packagers though say.
So there may well be a legitimate use-case for it.

Comment 4 Bryan O'Sullivan 2011-07-14 00:16:16 UTC
Yep, I use it every day.

Comment 6 Jens Petersen 2011-07-19 08:52:05 UTC
New upstream release (untested).

Spec: http://petersen.fedorapeople.org/cabal-dev/cabal-dev.spec
SRPM: http://petersen.fedorapeople.org/cabal-dev/cabal-dev-0.8-1.fc15.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3208868

I had to disable dynamic linking since ghc doesn't seem
to like building dynamically linked binaries with Template Haskell.

Comment 7 Jens Petersen 2011-07-21 02:44:43 UTC
Here's one that actually builds in mock (added missing template-haskell dep).

Spec: http://petersen.fedorapeople.org/cabal-dev/cabal-dev.spec
SRPM: http://petersen.fedorapeople.org/cabal-dev/cabal-dev-0.8-2.fc15.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3217224

Comment 8 Narasimhan 2011-07-29 18:17:36 UTC
[+]MUST: rpmlint must be run on every package. The output should be posted in the review.

cabal-dev.src: W: spelling-error Summary(en_US) sandboxing -> sand boxing, sand-boxing, sandbagging
The value of this tag appears to be misspelled. Please double-check.

cabal-dev.src: W: spelling-error %description -l en_US sandboxed -> sandboxes, sand boxed, sand-boxed
The value of this tag appears to be misspelled. Please double-check.

cabal-dev.src: W: spelling-error %description -l en_US ghc -> chg
The value of this tag appears to be misspelled. Please double-check.

cabal-dev.x86_64: W: spelling-error Summary(en_US) sandboxing -> sand boxing, sand-boxing, sandbagging
The value of this tag appears to be misspelled. Please double-check.

cabal-dev.x86_64: W: spelling-error %description -l en_US sandboxed -> sandboxes, sand boxed, sand-boxed
The value of this tag appears to be misspelled. Please double-check.

cabal-dev.x86_64: W: spelling-error %description -l en_US ghc -> chg
The value of this tag appears to be misspelled. Please double-check.

cabal-dev.x86_64: W: no-manual-page-for-binary cabal-dev
Each executable in standard binary directories should have a man page.

cabal-dev.x86_64: W: no-manual-page-for-binary fake-ghc-cabal-dev
Each executable in standard binary directories should have a man page.

2 packages and 1 specfiles checked; 0 errors, 8 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Naming-Yes
        Version-release - Matches
        License - OK
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Build Requires list - OK
        Summary and description - OK
        API documentation - OK

[+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual license.
[+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
LICENSE file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task.
md5sum cabal-dev-0.8-2.fc15.src/cabal-dev-0.8.tar.gz 
d6f39a18cb7427089f9d3e704c440409  cabal-dev-0.8-2.fc15.src/cabal-dev-0.8.tar.gz

 md5sum ~/Downloads/cabal-dev-0.8.tar.gz 
d6f39a18cb7427089f9d3e704c440409  /home/narasimhan/Downloads/cabal-dev-0.8.tar.gz

[+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
Built on x86_64.
[+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
[NA]MUST: Packages stores shared library files must call ldconfig in %post and %postun.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list.
[NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissable content.
Contains 00index.tar. However the tar seems to be empty.
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[+]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix (e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
[NA]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release}
[NA]MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[NA]MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section
[+]MUST: Packages must not own files or directories already owned by other packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Installed package. Works fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.

cabal2spec-diff is OK.

The pacakge ships 00-index.tar. Any idea why this is  being shipped?

Comment 9 Narasimhan 2011-08-01 13:07:24 UTC
From my discussion with Jens on irc, 00index.tar is a placeholder file used for initialization of cabal database.

APPROVED.

Comment 10 Jens Petersen 2011-08-02 02:16:32 UTC
Thank you for reviewing! :)


New Package SCM Request
=======================
Package Name: cabal-dev
Short Description: Haskell package sandboxing tool
Owners: petersen
Branches: f14 f15 f16
InitialCC: haskell-sig

Comment 11 Gwyn Ciesla 2011-08-02 10:16:16 UTC
Git done (by process-git-requests).

Comment 12 Fedora Update System 2011-08-03 06:58:03 UTC
cabal-dev-0.8-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/cabal-dev-0.8-2.fc15

Comment 13 Fedora Update System 2011-08-03 06:58:11 UTC
cabal-dev-0.8-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/cabal-dev-0.8-2.fc16

Comment 14 Jens Petersen 2011-08-03 07:00:39 UTC
Ah, I forget my clever comment 1 (no f14).

Comment 15 Fedora Update System 2011-08-03 19:14:52 UTC
cabal-dev-0.8-2.fc16 has been pushed to the Fedora 16 testing repository.

Comment 16 Fedora Update System 2011-08-12 10:52:51 UTC
cabal-dev-0.8-2.fc15 has been pushed to the Fedora 15 stable repository.

Comment 17 Fedora Update System 2011-08-12 18:26:17 UTC
cabal-dev-0.8-2.fc15 has been pushed to the Fedora 15 stable repository.

Comment 18 Fedora Update System 2011-08-22 15:10:51 UTC
cabal-dev-0.8-2.fc16 has been pushed to the Fedora 16 stable repository.

Comment 19 Jens Petersen 2012-12-07 05:36:15 UTC
I think it would be useful to have also for el6.

Package Change Request
======================
Package Name: cabal-dev
New Branches: el6
Owners: petersen
InitialCC: haskell-sig

Comment 20 Gwyn Ciesla 2012-12-07 13:16:56 UTC
Git done (by process-git-requests).

Comment 21 Fedora Update System 2012-12-10 09:37:15 UTC
cabal-dev-0.9.1-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/cabal-dev-0.9.1-1.el6

Comment 22 Fedora Update System 2012-12-27 20:04:07 UTC
cabal-dev-0.9.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.