Bug 689947
| Summary: | RFE: don't add a line in .gitignore if the file is already ignored by git | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Aillon <caillon> |
| Component: | fedora-packager | Assignee: | David Cantrell <dcantrell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 15 | CC: | dcantrell, dennis, rhbugs |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | fedora-packager-0.5.9.0-1.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-04-11 20:44:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christopher Aillon
2011-03-22 20:38:53 UTC
Something reasonable could be done here. Upon further looking, there is already logic in the code that will take the new line to be added and fnmatch it against any existing line in the ignore file (fnmatch is what git uses). If any of the existing lines match the proposed line then we don't add the proposed line. I just tested the logic with a *.bz2 entry in the file and the logic seems to do the right thing. I'm going to close this as WORKSFORME for now, but if you run across the issue again I'll happily re-open and look at the data. fedora-packager-0.5.8.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fedora-packager-0.5.8.1-1.fc15 fedora-packager-0.5.8.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/fedora-packager-0.5.8.1-1.fc14 fedora-packager-0.5.8.1-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/fedora-packager-0.5.8.1-1.fc13 fedora-packager-0.5.8.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-packager-0.5.8.1-1.el6 fedora-packager-0.5.8.1-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/fedora-packager-0.5.8.1-1.el5 Ignore all that bugspam, I had the wrong bug ID in the bodhi updates :/ fedora-packager-0.5.8.1-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. fedora-packager-0.5.9.0-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/fedora-packager-0.5.9.0-1.fc13 fedora-packager-0.5.9.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-packager-0.5.9.0-1.el6 fedora-packager-0.5.9.0-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/fedora-packager-0.5.9.0-1.el5 fedora-packager-0.5.8.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. fedora-packager-0.5.9.0-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. fedora-packager-0.5.9.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. fedora-packager-0.5.9.0-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |