Bug 691115 (python-kombu)
Summary: | Review Request: python-kombu - AMQP Messaging Framework for Python | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> | ||||
Component: | Package Review | Assignee: | Narasimhan <lakshminaras2002> | ||||
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | fedora-package-review, lakshminaras2002, metherid, mrunge, notting | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2011-07-14 16:42:27 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 691114 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Fabian Affolter
2011-03-26 20:19:46 UTC
Hi Fabian, The source code at this location kombu-1.0.6/kombu/utils/functional.py is taken from python 2.5 code. This needs to be mentioned in the spec file. However I am not sure whether the LICENSE field should be BSD and Python or just mention the above exception in a comment as done here http://rayvd.fedorapeople.org/python-webpy/python-webpy.spec I will draft an email to fedora legal and get it clarified. Also, other .py files in the kombu-1.0.6/kombu/utils/ directory do not have license text at the beginning of the file. The licensing of these files needs to be clarified with upstream. Thanks, I found this page. If the files are under difference licenses, then it is required to use multiple licenses in the License field and add relevant comments in the spec file. http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios Thanks Fab, I need this as a dependency of something else I am packaging. Please respond * Sat Mar 26 2011 Fabian Affolter <fabian> - 1.1.3.1 - Updated to new upstream version 1.1.3 - Fixed URL - examples added - Fixed License Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-kombu.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-kombu-1.1.3-1.fc15.src.rpm Thanks Fabian, I will complete the review by 26th. Hi Fabian, there are some rpmlint issues that need fixing.
>>python-kombu.noarch: W: incoherent-version-in-changelog 1.1.3.1 ['1.1.3-1.fc15', '1.1.3-1']
The latest entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.
1) Needs fixing
python-kombu.noarch: W: hidden-file-or-dir /usr/share/doc/python-kombu-1.1.3/docs/.static/.keep
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.
python-kombu.noarch: E: zero-length /usr/share/doc/python-kombu-1.1.3/docs/.static/.keep
python-kombu.noarch: W: hidden-file-or-dir /usr/share/doc/python-kombu-1.1.3/docs/.static
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.
python-kombu.noarch: W: hidden-file-or-dir /usr/share/doc/python-kombu-1.1.3/docs/.static
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.
2) I noticed that the docs folder has files which cannot be viewed in a browser. It also has a makefile. It turns out that the makefile can be used to generate html files. I have attached a modified spec file that does that. Although we don't have all the dependent modules in the repo to generate the docs, the makefile seems to be ok with that. I checked the generated docs and it seems to be usable.
3) For generating the docs, python-couchdb is needed (and could be used at runtime as well). However the tests fail if python-couchdb is installed. It seems that a required class definition is not available for python v > 2.7. This would definitely cause an issue at runtime. Could you contact upstream and ask for a fix.
Attaching the modified spec.
Created attachment 509911 [details]
patch to generate docs and fix evr in changelog
I approved python-msgpack a few minutes ago. Any update? No, at the moment I have no time to work on this package. *** This bug has been marked as a duplicate of bug 722407 *** |