| Summary: | Review Request: wmbinclock - Dockapp which shows the actual system time as binary clock | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mario Blättermann <mario.blaettermann> |
| Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, notting |
| Target Milestone: | --- | Flags: | iarnell:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | wmbinclock-0.5-2.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-05-19 04:58:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Mario Blättermann
2011-03-27 12:01:23 UTC
At first glance, this looks to be mostly okay; just a couple of minor issues.
You need to pass CFLAGS="%{?optflags}" to the build.
And there is inconsistent use of macros vs variables - but since we don't need to clean buildroot in %install, you can just remove the offending line.
Thanks for your hints. Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmbinclock.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/wmbinclock-0.5-2.fc14.src.rpm + source files match upstream.
ba268e66b59b100edb9da1cee064c258 wmbinclock-0.5.tar.bz2
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ license field matches the actual license.
GPLv2+
+ license is open source-compatible.
+ license text included.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ package builds in mock (locally)
+ package installs properly.
+ rpmlint has no meaningful complaints:
wmbinclock.src: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Paddock
wmbinclock.src: I: enchant-dictionary-not-found de
wmbinclock.src: W: spelling-error %description -l en_US Dockapp -> Dock app, Dock-app, Paddock
wmbinclock.x86_64: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Paddock
wmbinclock.x86_64: W: spelling-error %description -l en_US Dockapp -> Dock app, Dock-app, Paddock
wmbinclock.x86_64: E: incorrect-fsf-address /usr/share/doc/wmbinclock-0.5/COPYING
wmbinclock.x86_64: W: no-manual-page-for-binary wmBinClock
wmbinclock-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/wmbinclock-0.5/wmBinClock_mask.xbm
wmbinclock-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/wmbinclock-0.5/wmBinClock.c
3 packages and 0 specfiles checked; 3 errors, 5 warnings.
+ final provides and requires are sane
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
Again, you should advise upstream of the fsf address change and ask them to update their code. Would also be nice to get a man page too.
Otherwise, all appears okay. APPROVED.
Thanks for the review! There's no proper solution regarding the wrong FSF address. Upstream is dead for ages. Either we patch/replace such files in general, or we do nothing. See bug #690919. Perhaps I will write a man page and add it to the package next weeks. New Package SCM Request ======================= Package Name: wmbinclock Short Description: Dockapp which shows the actual system time as binary clock Owners: mariobl Branches: f14 f15 Git done (by process-git-requests). wmbinclock-0.5-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/wmbinclock-0.5-2.fc15 wmbinclock-0.5-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/wmbinclock-0.5-2.fc14 wmbinclock-0.5-2.fc14 has been pushed to the Fedora 14 testing repository. wmbinclock-0.5-2.fc15 has been pushed to the Fedora 15 stable repository. wmbinclock-0.5-2.fc14 has been pushed to the Fedora 14 stable repository. |