Bug 691997
| Summary: | Review Request: nhn-nanum-fonts - Nanum family of Korean TrueType fonts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daiki Ueno <dueno> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | cwryu, fedora-package-review, notting, panemade, sangu.fedora |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | nhn-nanum-fonts-3.010-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-04-05 21:32:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Daiki Ueno
2011-03-30 06:39:27 UTC
Review: + koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=2962531 + source verified as (sha1sum) 1cbfffdf8e5f81915642340560fb2ca7c1d08ef5 NanumFont_TTF_ALL.zip 1cbfffdf8e5f81915642340560fb2ca7c1d08ef5 ../SOURCES/NanumFont_TTF_ALL.zip + packaging looks fine. Suggestion 1) If -common subpackage does not contain any files then it should be dropped. 2) Also, NanumPen.ttf and NanumBrush.ttf fonts contain 1.100 version while other fonts have 3.010 version. We can also create versioned subpackages for those 2 fonts. 3) If this is going to be packaged for Fedora 13 onwards then drop %clean section and cleanup of buildroot in %install. APPROVED. Thanks for the review, Parag. I'll reflect your suggestions before importing the package into the git. New Package SCM Request ======================= Package Name: nhn-nanum-fonts Short Description: Nanum family of Korean TrueType fonts Owners: ueno Branches: f14 f15 InitialCC: fonts-sig i18n-team Git done (by process-git-requests). nhn-nanum-fonts-3.010-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/nhn-nanum-fonts-3.010-1.fc15 nhn-nanum-fonts-3.010-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/nhn-nanum-fonts-3.010-1.fc14 nhn-nanum-fonts-3.010-1.fc14 has been pushed to the Fedora 14 testing repository. nhn-nanum-fonts-3.010-1.fc15 has been pushed to the Fedora 15 stable repository. nhn-nanum-fonts-3.010-1.fc14 has been pushed to the Fedora 14 stable repository. Its just been learnt that license information for this package is available in English at http://translate.google.com/translate?hl=en&sl=auto&tl=en&u=http%3A%2F%2Fhelp.naver.com%2Fops%2Fstep2%2Ffaq.nhn%3FfaqId%3D15879 Thanks to tagoh. |