Bug 691997 - Review Request: nhn-nanum-fonts - Nanum family of Korean TrueType fonts
Summary: Review Request: nhn-nanum-fonts - Nanum family of Korean TrueType fonts
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-30 06:39 UTC by Daiki Ueno
Modified: 2012-11-21 06:13 UTC (History)
5 users (show)

Fixed In Version: nhn-nanum-fonts-3.010-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-05 21:32:11 UTC
Type: ---
Embargoed:
panemade: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Daiki Ueno 2011-03-30 06:39:27 UTC
Spec URL: http://ueno.fedorapeople.org/nhn-nanum-fonts/nhn-nanum-fonts.spec
SRPM URL: http://ueno.fedorapeople.org/nhn-nanum-fonts/nhn-nanum-fonts-3.010-1.fc14.src.rpm
Description:
Nanum fonts are collection of commonly-used Myeongjo and Gothic Korean
font families, designed by Sandoll Communication and Fontrix. The
publisher is NHN Corporation.

Font description page:
https://fedoraproject.org/wiki/NHN_Nanum_fonts

Comment 1 Parag AN(पराग) 2011-03-31 05:54:48 UTC
Review:
+ koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=2962531
+ source verified as (sha1sum)
1cbfffdf8e5f81915642340560fb2ca7c1d08ef5  NanumFont_TTF_ALL.zip
1cbfffdf8e5f81915642340560fb2ca7c1d08ef5  ../SOURCES/NanumFont_TTF_ALL.zip
+ packaging looks fine.

Suggestion
1) If -common subpackage does not contain any files then it should be dropped.
2) Also, NanumPen.ttf and NanumBrush.ttf fonts contain 1.100 version while other fonts have 3.010 version. We can also create versioned subpackages for those 2 fonts.
3) If this is going to be packaged for Fedora 13 onwards then drop %clean section and cleanup of buildroot in %install.

APPROVED.

Comment 2 Daiki Ueno 2011-03-31 06:32:00 UTC
Thanks for the review, Parag.  I'll reflect your suggestions before importing the package into the git.

New Package SCM Request
=======================
Package Name: nhn-nanum-fonts
Short Description: Nanum family of Korean TrueType fonts
Owners: ueno
Branches: f14 f15
InitialCC: fonts-sig i18n-team

Comment 3 Jason Tibbitts 2011-03-31 13:25:23 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2011-04-01 03:01:28 UTC
nhn-nanum-fonts-3.010-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/nhn-nanum-fonts-3.010-1.fc15

Comment 5 Fedora Update System 2011-04-01 03:01:36 UTC
nhn-nanum-fonts-3.010-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/nhn-nanum-fonts-3.010-1.fc14

Comment 6 Fedora Update System 2011-04-01 18:20:02 UTC
nhn-nanum-fonts-3.010-1.fc14 has been pushed to the Fedora 14 testing repository.

Comment 7 Fedora Update System 2011-04-05 21:32:06 UTC
nhn-nanum-fonts-3.010-1.fc15 has been pushed to the Fedora 15 stable repository.

Comment 8 Fedora Update System 2011-04-11 20:56:27 UTC
nhn-nanum-fonts-3.010-1.fc14 has been pushed to the Fedora 14 stable repository.

Comment 9 Parag AN(पराग) 2012-11-21 06:13:42 UTC
Its just been learnt that license information for this package is available in English at http://translate.google.com/translate?hl=en&sl=auto&tl=en&u=http%3A%2F%2Fhelp.naver.com%2Fops%2Fstep2%2Ffaq.nhn%3FfaqId%3D15879

Thanks to tagoh.


Note You need to log in before you can comment on or make changes to this bug.