Bug 692124

Summary: Please add /run to filesystem
Product: [Fedora] Fedora Reporter: Michal Schmidt <mschmidt>
Component: filesystemAssignee: Ondrej Vasik <ovasik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 15CC: lpoetter, notting, ovasik
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: filesystem-2.4.40-1.fc15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-04-05 21:31:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
proposed patch
none
revised patch none

Description Michal Schmidt 2011-03-30 13:28:03 UTC
Description of problem:
systemd, udev, dracut, lvm and possibly others want to use the new /run directory. See:
http://lists.fedoraproject.org/pipermail/devel/2011-March/150031.html
Currently the directory is created by systemd (since version 21). It should be owned by the filesystem package instead, like other directories.

Comment 1 Ondrej Vasik 2011-03-30 14:17:41 UTC
Thanks for heads-up ... makes sense ... do we really need that for F-15 or Rawhide change is enough ?

Comment 2 Michal Schmidt 2011-03-30 14:19:51 UTC
See the discussion on the devel list. Lennart and others want it for F-15. It is slightly controversial though (e.g. bug 692097).

Comment 3 Ondrej Vasik 2011-03-30 14:34:34 UTC
Well ok, I saw the number of messages in the thread and I was scared enough to read it through :), I'll wait with f15 update for few days ... just to calm down and see what's the result of discussion :) .

Comment 4 Harald Hoyer 2011-03-31 14:43:08 UTC
Created attachment 489111 [details]
proposed patch

Comment 5 Ondrej Vasik 2011-03-31 14:44:18 UTC
I'll use it in tomorrow update - with only minor change (alphabetical reordering), thanks.

Comment 6 Harald Hoyer 2011-03-31 14:50:06 UTC
Created attachment 489113 [details]
revised patch

Comment 7 Ondrej Vasik 2011-03-31 15:04:17 UTC
Commited in fedorahosted git - https://fedorahosted.org/filesystem/changeset/d2588ae1977dfc57041742fb9e2ffffc02b6562b . Should I care about /run/lock as well ? Or this one is handled elsewhere ... ?

Comment 8 Bill Nottingham 2011-03-31 15:09:06 UTC
/var/lock perhaps should be 775 root.lock to match systemd perms.

Comment 9 Bill Nottingham 2011-03-31 15:13:16 UTC
Also, something probably still needs to create /var/lock/subsys on install, unless you're requiring a reboot with tmpfiles.d to make sure things work.

Comment 10 Lennart Poettering 2011-03-31 15:28:40 UTC
(In reply to comment #7)
> Commited in fedorahosted git -
> https://fedorahosted.org/filesystem/changeset/d2588ae1977dfc57041742fb9e2ffffc02b6562b
> . Should I care about /run/lock as well ? Or this one is handled elsewhere ...

No, /run/lock is not necessary in filesystem, since that is on a tmpfs and hence would not survive a reboot anyway. systemd-tmpfiles creates that dir based on the data in /etc/tmpfiles.d/systemd.conf.

Comment 11 Lennart Poettering 2011-03-31 15:29:33 UTC
(In reply to comment #9)
> Also, something probably still needs to create /var/lock/subsys on install,
> unless you're requiring a reboot with tmpfiles.d to make sure things work.

/etc/tmpfiles.d/systemd.conf creates that as /run/lock/subsys which also appears as /var/lock/subsys.

Comment 12 Ondrej Vasik 2011-03-31 15:37:05 UTC
(In reply to comment #8)
> /var/lock perhaps should be 775 root.lock to match systemd perms.

I don't think so, see https://fedorahosted.org/filesystem/changeset/8311d3abe6f96961ddab805b310a2c212cf44800 and discussion in https://bugzilla.redhat.com/show_bug.cgi?id=581884 ... root:lock 775 should be no longer required by lockdev - and /var/lock is not systemd specific thing.

Comment 13 Bill Nottingham 2011-03-31 15:50:10 UTC
If that's the case, then perhaps we should fix systemd to change the perms of /var/lock back.

Comment 14 Ondrej Vasik 2011-03-31 19:05:46 UTC
Yep, exactly, systemd should be fixed...

Comment 15 Lennart Poettering 2011-03-31 19:41:02 UTC
Hmm, can we get this built for F15 too, please?

Comment 16 Lennart Poettering 2011-03-31 21:42:56 UTC
I have now fixed systemd git to use 755 root:root on /var/lock and 775 root:lock on /var/lock/lockdev.

Comment 17 Fedora Update System 2011-04-01 07:42:28 UTC
filesystem-2.4.39-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/filesystem-2.4.39-1.fc15

Comment 18 Fedora Update System 2011-04-02 02:47:47 UTC
Package filesystem-2.4.39-1.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing filesystem-2.4.39-1.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/filesystem-2.4.39-1.fc15
then log in and leave karma (feedback).

Comment 19 Fedora Update System 2011-04-05 21:31:30 UTC
filesystem-2.4.40-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.