Bug 692124
Summary: | Please add /run to filesystem | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michal Schmidt <mschmidt> | ||||||
Component: | filesystem | Assignee: | Ondrej Vasik <ovasik> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 15 | CC: | lpoetter, notting, ovasik | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | filesystem-2.4.40-1.fc15 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2011-04-05 21:31:45 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Michal Schmidt
2011-03-30 13:28:03 UTC
Thanks for heads-up ... makes sense ... do we really need that for F-15 or Rawhide change is enough ? See the discussion on the devel list. Lennart and others want it for F-15. It is slightly controversial though (e.g. bug 692097). Well ok, I saw the number of messages in the thread and I was scared enough to read it through :), I'll wait with f15 update for few days ... just to calm down and see what's the result of discussion :) . Created attachment 489111 [details]
proposed patch
I'll use it in tomorrow update - with only minor change (alphabetical reordering), thanks. Created attachment 489113 [details]
revised patch
Commited in fedorahosted git - https://fedorahosted.org/filesystem/changeset/d2588ae1977dfc57041742fb9e2ffffc02b6562b . Should I care about /run/lock as well ? Or this one is handled elsewhere ... ? /var/lock perhaps should be 775 root.lock to match systemd perms. Also, something probably still needs to create /var/lock/subsys on install, unless you're requiring a reboot with tmpfiles.d to make sure things work. (In reply to comment #7) > Commited in fedorahosted git - > https://fedorahosted.org/filesystem/changeset/d2588ae1977dfc57041742fb9e2ffffc02b6562b > . Should I care about /run/lock as well ? Or this one is handled elsewhere ... No, /run/lock is not necessary in filesystem, since that is on a tmpfs and hence would not survive a reboot anyway. systemd-tmpfiles creates that dir based on the data in /etc/tmpfiles.d/systemd.conf. (In reply to comment #9) > Also, something probably still needs to create /var/lock/subsys on install, > unless you're requiring a reboot with tmpfiles.d to make sure things work. /etc/tmpfiles.d/systemd.conf creates that as /run/lock/subsys which also appears as /var/lock/subsys. (In reply to comment #8) > /var/lock perhaps should be 775 root.lock to match systemd perms. I don't think so, see https://fedorahosted.org/filesystem/changeset/8311d3abe6f96961ddab805b310a2c212cf44800 and discussion in https://bugzilla.redhat.com/show_bug.cgi?id=581884 ... root:lock 775 should be no longer required by lockdev - and /var/lock is not systemd specific thing. If that's the case, then perhaps we should fix systemd to change the perms of /var/lock back. Yep, exactly, systemd should be fixed... Hmm, can we get this built for F15 too, please? I have now fixed systemd git to use 755 root:root on /var/lock and 775 root:lock on /var/lock/lockdev. filesystem-2.4.39-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/filesystem-2.4.39-1.fc15 Package filesystem-2.4.39-1.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing filesystem-2.4.39-1.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/filesystem-2.4.39-1.fc15 then log in and leave karma (feedback). filesystem-2.4.40-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. |