| Summary: | colorgrep profile.d scripts overwrite and leak $COLORS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | ||||
| Component: | grep | Assignee: | Jaroslav Škarvada <jskarvad> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 14 | CC: | jskarvad, lkundrak | ||||
| Target Milestone: | --- | Keywords: | Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | grep-2.7-5.fc15 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-04-12 21:32:01 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
Oh, and instead of testing existence of "-e /etc/GREP_COLORS" it would be better to test for "-r /etc/GREP_COLORS". ...and another "oh": I suppose the "#! /bin/csh -f" shebang is unnecessary in the csh version and could be removed. Thanks. grep-2.7-5.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/grep-2.7-5.fc15 grep-2.7-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/grep-2.7-2.fc14 Package grep-2.7-2.fc14: * should fix your issue, * was pushed to the Fedora 14 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing grep-2.7-2.fc14' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/grep-2.7-2.fc14 then log in and leave karma (feedback). grep-2.7-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. grep-2.7-5.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 489561 [details] Don't overwrite/leak $COLORS The colorgrep profile.d scripts unnecessarily overwrite the $COLORS environment variable and "leak" it into the environment; fix attached.