Bug 693058 - colorgrep profile.d scripts overwrite and leak $COLORS
Summary: colorgrep profile.d scripts overwrite and leak $COLORS
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: grep
Version: 14
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jaroslav Škarvada
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-02 09:29 UTC by Ville Skyttä
Modified: 2011-04-15 21:51 UTC (History)
2 users (show)

Fixed In Version: grep-2.7-5.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-12 21:32:01 UTC
Type: ---


Attachments (Terms of Use)
Don't overwrite/leak $COLORS (981 bytes, patch)
2011-04-02 09:29 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2011-04-02 09:29:34 UTC
Created attachment 489561 [details]
Don't overwrite/leak $COLORS

The colorgrep profile.d scripts unnecessarily overwrite the $COLORS environment variable and "leak" it into the environment; fix attached.

Comment 1 Ville Skyttä 2011-04-02 09:32:58 UTC
Oh, and instead of testing existence of "-e /etc/GREP_COLORS" it would be better to test for "-r /etc/GREP_COLORS".

Comment 2 Ville Skyttä 2011-04-02 09:34:44 UTC
...and another "oh": I suppose the "#! /bin/csh -f" shebang is unnecessary in the csh version and could be removed.

Comment 3 Jaroslav Škarvada 2011-04-04 08:34:01 UTC
Thanks.

Comment 4 Fedora Update System 2011-04-04 08:52:51 UTC
grep-2.7-5.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/grep-2.7-5.fc15

Comment 5 Fedora Update System 2011-04-04 08:53:47 UTC
grep-2.7-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/grep-2.7-2.fc14

Comment 6 Fedora Update System 2011-04-05 05:21:24 UTC
Package grep-2.7-2.fc14:
* should fix your issue,
* was pushed to the Fedora 14 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing grep-2.7-2.fc14'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/grep-2.7-2.fc14
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2011-04-12 21:31:56 UTC
grep-2.7-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2011-04-15 21:50:55 UTC
grep-2.7-5.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.