Bug 693746

Summary: [RHEL5][RFE][PATCH] Add ability to set various ethtool options in ifcfg-ethX
Product: Red Hat Enterprise Linux 5 Reporter: Frank Hirtz <fhirtz>
Component: initscriptsAssignee: initscripts Maintenance Team <initscripts-maint-list>
Status: CLOSED WONTFIX QA Contact: qe-baseos-daemons
Severity: low Docs Contact:
Priority: low    
Version: 5.8CC: fhirtz, notting
Target Milestone: rcKeywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: 693583 Environment:
Last Closed: 2011-04-05 15:34:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Initscripts patch none

Description Frank Hirtz 2011-04-05 13:56:02 UTC
Created attachment 489985 [details]
Initscripts patch

+++ This bug was initially created as a clone of Bug #693583 +++

Created attachment 489884 [details]
Initscripts patch

Description of problem:
Currently, only "ethtool -s" options can be set in ifcfg-ethX files. I've added a bit of extra code that'll add the ability to set for the other modes. This is done via the addition of the following section to where we parse ETHTOOL_OPTS presently:

<snip>

     if [ -n "$ETHTOOL_OPTS" ] ; then
         /sbin/ethtool -s ${REALDEVICE} $ETHTOOL_OPTS
     fi
+    if [ -n "$ETHTOOL_PAUSE_OPTS" ] ; then
+        /sbin/ethtool -A ${REALDEVICE} $ETHTOOL_PAUSE_OPTS
+    fi
+    if [ -n "$ETHTOOL_RING_OPTS" ] ; then
+        /sbin/ethtool -G ${REALDEVICE} $ETHTOOL_RING_OPTS
+    fi
+    if [ -n "$ETHTOOL_COALESCE_OPTS" ] ; then
+        /sbin/ethtool -C ${REALDEVICE} $ETHTOOL_COALESCE_OPTS
+    fi
+    if [ -n "$ETHTOOL_OFFLOAD_OPTS" ] ; then
+        /sbin/ethtool -K ${REALDEVICE} $ETHTOOL_OFFLOAD_OPTS
+    fi
+    if [ -n "$IFCONFIG_OPTS" ] ; then
+       /sbin/ifconfig ${REALDEVICE} $IFCONFIG_OPTS
+    fi

     exit 0
<snip>

Patch is attached for RHEL6, but the general workup works fine for RHEL4+

So, this is done in the few places in ifup-eth where we look for options. It adds a consistent way to set options using our defined config files so we don't have to resort to rc.local or any such. Please let me know if you have questions or concerns.

Thank you,

Frank.

Version-Release number of selected component (if applicable):
initscripts-all

Comment 1 Bill Nottingham 2011-04-05 15:20:33 UTC
NAK on this approach, see https://bugzilla.redhat.com/show_bug.cgi?id=693583#c1.

Comment 2 RHEL Program Management 2011-04-05 15:34:47 UTC
Development Management has reviewed and declined this request.  You may appeal
this decision by reopening this request.