RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 693583 - [RHEL6][RFE][PATCH] Add ability to set various ethtool options in ifcfg-ethX
Summary: [RHEL6][RFE][PATCH] Add ability to set various ethtool options in ifcfg-ethX
Keywords:
Status: CLOSED DUPLICATE of bug 692410
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: initscripts
Version: 6.2
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: initscripts Maintenance Team
QA Contact: qe-baseos-daemons
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-05 00:28 UTC by Frank Hirtz
Modified: 2011-06-23 17:50 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
: 693746 (view as bug list)
Environment:
Last Closed: 2011-04-05 15:18:18 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Initscripts patch (3.21 KB, application/octet-stream)
2011-04-05 00:28 UTC, Frank Hirtz
no flags Details

Description Frank Hirtz 2011-04-05 00:28:01 UTC
Created attachment 489884 [details]
Initscripts patch

Description of problem:
Currently, only "ethtool -s" options can be set in ifcfg-ethX files. I've added a bit of extra code that'll add the ability to set for the other modes. This is done via the addition of the following section to where we parse ETHTOOL_OPTS presently:

<snip>

     if [ -n "$ETHTOOL_OPTS" ] ; then
         /sbin/ethtool -s ${REALDEVICE} $ETHTOOL_OPTS
     fi
+    if [ -n "$ETHTOOL_PAUSE_OPTS" ] ; then
+        /sbin/ethtool -A ${REALDEVICE} $ETHTOOL_PAUSE_OPTS
+    fi
+    if [ -n "$ETHTOOL_RING_OPTS" ] ; then
+        /sbin/ethtool -G ${REALDEVICE} $ETHTOOL_RING_OPTS
+    fi
+    if [ -n "$ETHTOOL_COALESCE_OPTS" ] ; then
+        /sbin/ethtool -C ${REALDEVICE} $ETHTOOL_COALESCE_OPTS
+    fi
+    if [ -n "$ETHTOOL_OFFLOAD_OPTS" ] ; then
+        /sbin/ethtool -K ${REALDEVICE} $ETHTOOL_OFFLOAD_OPTS
+    fi
+    if [ -n "$IFCONFIG_OPTS" ] ; then
+       /sbin/ifconfig ${REALDEVICE} $IFCONFIG_OPTS
+    fi

     exit 0
<snip>

Patch is attached for RHEL6, but the general workup works fine for RHEL4+

So, this is done in the few places in ifup-eth where we look for options. It adds a consistent way to set options using our defined config files so we don't have to resort to rc.local or any such. Please let me know if you have questions or concerns.

Thank you,

Frank.

Version-Release number of selected component (if applicable):
initscripts-all

Comment 1 Bill Nottingham 2011-04-05 15:18:18 UTC
This approach offers a potentially unbounded set of random new options; as such, I don't really care for it. I'd much rather prefer something along the lines of bug 692410.

(And I'd prefer they just do it via udev rules and get it out of the init scripts entirely, but everyone seems to object to doing it there.)

*** This bug has been marked as a duplicate of bug 692410 ***

Comment 2 Frank Hirtz 2011-04-05 19:07:44 UTC
> *** Bug 693583 has been marked as a duplicate of this bug. ***

I'm not overly concerned with the specific implementation provided that we have
the functionality, but while this method is more compact than what I was
proposing, how do we handle the case where we want to set the ring parameters,
offload parameters, and say, the speed/duplex? It seems that this method would
let you set one of those, but that's it?

<in referenced ticket as well>


Note You need to log in before you can comment on or make changes to this bug.