Bug 694716
| Summary: | 15 Beta RC1 DVDs fail repoclosure | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andre Robatino <robatino> |
| Component: | spin-kickstarts | Assignee: | Bill Nottingham <notting> |
| Status: | CLOSED ERRATA | QA Contact: | Bill Nottingham <notting> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 15 | CC: | awilliam, bruno, dcantrell, jlaska, kevin, maxamillion, rbergero, rvokal, vanmeeuwen+fedora |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | AcceptedBlocker | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-04-11 15:50:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 657618 | ||
|
Description
Andre Robatino
2011-04-08 05:50:19 UTC
Qualifies as a beta blocker per the Alpha criteria [1] "# There must be no file conflicts (cases where the files in some packages conflict but the packages have explicit Conflicts: tags are acceptable) or unresolved package dependencies during a media-based (CD/DVD) install " [1] http://fedoraproject.org/wiki/Fedora_15_Alpha_Release_Criteria The install ks explicitly excludes xfwm4* from the repo. We either need to exclude more xfce stuff or less. Note that pungi is an inclusive resolver, and will pull in ALL packages that satisfy a dependency. I don't know where the exact scripts are to run a test build, but it might be worth trying with the addition of --excludes=xfce* since I doubt that any such packages are supposed to be brought in. +1, clearly hits the criterion. It looks like excluding xfce* is a bad idea since @xfce-desktop is specifically included. I'm going to check the commit log and see if I can find the reason for the exclusion. We explicitly added xfce and lxde to the install dvd this release. so the exclude line needs removal +1 for hitting criterion Here is the info: http://git.fedorahosted.org/git/?p=spin-kickstarts.git;a=commitdiff;h=09248faa40eaa2d07fbabf7cef7bd7db05c6e478;hp=6b1bb145d8b380d66c41fd60862e26f8d8a7c68f The commit description is: Keep xfce stuff off the media This is odd in light of @xfce-desktop being included explicitly. I'd be inclined to just drop those extra excludes. Considering the proximity in time to the kernel-PAE removal, I think this is likely related to the CD1 being over size issue that came up close to a release and some compromises were made to get things working. I don't remember where I caught glimpses of that discussion, but I'll see if I can find it. I'm testing a pungi DVD.iso compose without --exclude xfwm4 ... This might have been somewhat related to bug 642557, where some stuff needed to get added to the first image of split media. The change to reduce the size happened the next day. You might also need to drop --exclude xfce4-notifyd as that was added in the same commit as --exclude xfwm4. But if your change works, I wouldn't worry about it more now. Are we finally dropping split media for this release? I thought I remembered that we were finally going to do that, but I don't know for sure. If we are keeping them, we may need to go back and look for issues there. This comments in the spin-kickstarts package do indicate the problem for which the excludes were added were related to a split media problem: * Wed Oct 20 2010 Jesse Keating <jkeating> - 0.14.4-3 - Include patchs to scrub xfce and more kernel-PAE* from the media * Tue Oct 19 2010 Jesse Keating <jkeating> 0.14.4-1 - Fix i386 split CD install media by scrubbing kernel-PAE We have already reverted the kernel-pae exclusion. If split media is no longer a problem, then I think removing --exclude xfce4-notifyd --exclude xfwm4* should also be done. I am also going to move this to spin-kickstarts, since that seems to be where this belongs. It does seem FESCO agreed to drop split media. So I am going to commit a fix to the install kickstart file. http://meetbot.fedoraproject.org/fedora-meeting/2010-10-20/fesco.2010-10-20-18.30.html The following commit to spin-kickstarts should resolve this: http://git.fedorahosted.org/git/?p=spin-kickstarts.git;a=commit;h=2c5051ad29af8c10905c3d45678c6b8316152e95 (In reply to comment #13) > The following commit to spin-kickstarts should resolve this: > http://git.fedorahosted.org/git/?p=spin-kickstarts.git;a=commit;h=2c5051ad29af8c10905c3d45678c6b8316152e95 Applying that commit resolved the issue in my testing. # mount -o ro,loop /var/lib/mock/fedora-15-i386/root/15/Fedora/i386/iso/Fedora-15-i386-DVD.iso /media/ # repoclosure --repoid=media --repofrompath=media,file:///media -t -a noarch -a $(uname -i) -n Added media repo from file:///media Reading in repository metadata - please wait.... Checking Dependencies Repos looked at: 1 media Num Packages in Repos: 2941 15 Beta RC2 DVDs pass repoclosure and file conflicts tests. (In reply to comment #15) > 15 Beta RC2 DVDs pass repoclosure and file conflicts tests. Thanks Andre! should we close the bug, then? |