Bug 694915
| Summary: | filename quoting problem in livecd-iso-to-disk | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | cam <camilo> | ||||||||
| Component: | livecd-tools | Assignee: | Brian Lane <bcl> | ||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 14 | CC: | adam.stokes, bcling, bcl, bruno, dhuff, Jasper.Hartline, katzj, stephent98, susi.lehtola | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | livecd-tools-17.0-1 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2011-08-11 23:38:58 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
cam
2011-04-08 20:32:05 UTC
(In reply to comment #0) > Description of problem: > After downloading an iso with the same name as a previous one, the browser > often saves the file with a space and brackets in the new filename, eg. ... I used do try to do this too. My workaround is to create separate directories for each of the candidates, which eliminates naming conflicts. $ ls -F fedora/F14/ F14-Alpha/ F14-Beta-RC1/ F14-Beta-RC2/ F14-Beta-RC3/ F14-Final-RC1/ (In reply to comment #1) [...] > My workaround is to create separate directories for each of the candidates, > which eliminates naming conflicts. Renaming the file also works around the problem, although we should probably fix the bug anyway. I didn't realise it was just a bash script, I will attach a patch that attempts to fix the problem. Created attachment 490882 [details]
patch for livecd-iso-to-disk to quote $ISO in case it has unusual characters
I tried this with the filename that caused the bug and the disk was written correctly.
Note that this patch doesn't apply against current upstream since most references to $ISO are now $SRC. I am not sure if that change is going to make it to F14 or not. If not I don't see a problem with doing two patches. F14 has enough life left, and the fix is simple enough, that I think its worth doing. Created attachment 490901 [details]
f15 branch version of the patch
I have made an f15 branch version of the patch. I didn't check, but likely this would work for the master branch as well.
I looked at master now and the patch probably won't apply cleanly. So I'll look at making one for master as well. Created attachment 490903 [details]
Patch for master branch
There is now a patch for master as well. I didn't actually test either of my two patches yet. But I can do some testing and get these applied if I get some agreement for another developer that this is a good way to go.
*** Bug 698070 has been marked as a duplicate of this bug. *** *** Bug 715262 has been marked as a duplicate of this bug. *** |